From owner-cvs-all@FreeBSD.ORG Sun Jul 3 01:10:40 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F15A216AC79; Sun, 3 Jul 2005 00:58:39 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3325B446B6; Sun, 3 Jul 2005 00:42:58 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 1480E6DCFC; Sat, 2 Jul 2005 17:38:12 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 6E49E5C99C for ; Tue, 25 Jan 2005 07:44:48 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 3D4A35602D for ; Tue, 25 Jan 2005 15:44:48 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 8AEFA16A4EB; Tue, 25 Jan 2005 15:44:45 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 26ADE16A4D0; Tue, 25 Jan 2005 15:44:42 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E079316A4CF; Tue, 25 Jan 2005 15:44:40 +0000 (GMT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88C0243D5C; Tue, 25 Jan 2005 15:44:40 +0000 (GMT) (envelope-from nectar@celabo.org) Received: from lum.celabo.org (lum.celabo.org [10.0.1.107]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "lum.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.celabo.org (Postfix) with ESMTP id 1B5223E2C23; Tue, 25 Jan 2005 09:44:40 -0600 (CST) Received: by lum.celabo.org (Postfix, from userid 1001) id 4F4FA594FD5; Tue, 25 Jan 2005 09:44:39 -0600 (CST) From: "Jacques A. Vidrine" To: Poul-Henning Kamp Message-ID: <20050125154439.GH5662@lum.celabo.org> Mail-Followup-To: "Jacques A. Vidrine" , Poul-Henning Kamp , Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20050125153729.GF5662@lum.celabo.org> <86669.1106667584@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86669.1106667584@critter.freebsd.dk> X-Url: http://www.celabo.org/ User-Agent: Mutt/1.5.6i Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: Andrey Chernov , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:40 -0000 X-Original-Date: Tue, 25 Jan 2005 09:44:39 -0600 X-List-Received-Date: Sun, 03 Jul 2005 01:10:40 -0000 On Tue, Jan 25, 2005 at 04:39:44PM +0100, Poul-Henning Kamp wrote: > In message <20050125153729.GF5662@lum.celabo.org>, "Jacques A. Vidrine" writes: > >On Tue, Jan 25, 2005 at 12:42:26PM +0300, Andrey Chernov wrote: > >> On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote: > >> > sys/kern sys_generic.c > >> > Log: > >> > Previously a read of zero bytes got handled in devfs:vop_read() but I > >> > missed that when the vnode bypass was introduced. > >> > > >> > Deal with zero length transfers before we even get to fo_ops->fo_read(). > >> > >> Please back it out. Zero bytes read may affect atime, now not. > > > >I do not think that a zero byte read should not affect atime. > > Explain to me then why open+mmap doesn't affect atime isn't a bigger problem ? Er. (a) Sorry I missed the rest of the thread before posting--- I do not really have anything to add at this point. (b) I put one too many negatives in the sentence above: s/do not think/think/. (^_^;) Cheers, -- Jacques A Vidrine / NTT/Verio nectar@celabo.org / jvidrine@verio.net / nectar@FreeBSD.org