From owner-svn-src-head@freebsd.org Mon Oct 17 08:45:12 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C652C14C36 for ; Mon, 17 Oct 2016 08:45:12 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 26433189C for ; Mon, 17 Oct 2016 08:45:11 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-lf0-x22e.google.com with SMTP id b75so276850751lfg.3 for ; Mon, 17 Oct 2016 01:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=kQplLbPaq5755lzPfLZ6aMELIpnag5XjePewTZGm39U=; b=fF1lkxbe2jMghlZn8NDYivABTMtiAiOsYnBPI1AaEYEHIM5y5zOtLQAKsZF+wbeiI8 hcQ+LqGlcYpYX9Kie81uFVwuejaQwdJGHN8D0ykQwQjGjGfy7jpjJOdj5EGjiuyAc49P 5r8gL+cI8flUdlL2/cKl6FSY5Bb53p00+ikETXicxO1P/LKCtP5UOeuV9oQHYPduURj2 rAVE59rJ7zFoQmFQe4kq8iK/kkHpGR/2Xd7xZysQrezhguZwcJTd71+XUlpujLpK3g/4 JDO3NOVH5xa60lDnTvrcTK0n3VvoWoy8ZMET433Xz2c/0xR0bM2IakAwV31+WWlBb6wk pQRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=kQplLbPaq5755lzPfLZ6aMELIpnag5XjePewTZGm39U=; b=AhYpnfdtXhi3ARWW845f0FtFx2kLhPkHVpmuc6iLUTVjq0yW0vVf+BiRsEx6CMeTa+ d5/oQ4aCtTxD/RIPBmG9EoPvbnuc2TgV/oftwFYeM1zTtBub8cVtrbAn4pW1sFCJimVt dqwHmP63doSCGDFSyr1mWNiulomiDXPgWakeX+y/7JKQirJeFSzrshnQt5w2PP16RKot T3ziGpb7iHXsZwmurGIMhZI8NTmCY8cNDiLjKWqiBCbyhdUe82XLBdzvvcx4lrXRcLMJ B8esYMh5MPxfcKQt6ZdVHB3DGMksSOpg2foPXPy6rmicnxBRxNMkVkeXJR+11HESStWF i25Q== X-Gm-Message-State: AA6/9RnSh5S2HZvJHesFsJj/gv+evylhNcey+b16ebZ9Ghv7dD/bYzBWxZ50YPc22s2WAZbR X-Received: by 10.25.41.205 with SMTP id p196mr12942237lfp.2.1476693909947; Mon, 17 Oct 2016 01:45:09 -0700 (PDT) Received: from [10.10.1.58] ([185.97.61.26]) by smtp.gmail.com with ESMTPSA id 13sm7366709ljb.22.2016.10.17.01.45.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Oct 2016 01:45:09 -0700 (PDT) Subject: Re: svn commit: r307507 - head/sys/cam/scsi To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201610170835.u9H8ZvQi037190@repo.freebsd.org> From: Steven Hartland Message-ID: <14e5b11b-d623-fe1b-2ad3-088961d1ffab@multiplay.co.uk> Date: Mon, 17 Oct 2016 09:45:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <201610170835.u9H8ZvQi037190@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 08:45:12 -0000 IIRC the timeout for this was intentionally lower than the default, might be worth just checking. On 17/10/2016 09:35, Alexander Motin wrote: > Author: mav > Date: Mon Oct 17 08:35:56 2016 > New Revision: 307507 > URL: https://svnweb.freebsd.org/changeset/base/307507 > > Log: > Consider device as clean even if SYNCHRONIZE CACHE failed. > > If device reservation was preempted by other initiator, our sync request > will always fail. Without this change CAM tried to sync cache on every > following device close, including numerous GEOM tasting opens/closes, > causing lots of useless noise in logs. > > While there, increase SYNCHRONIZE CACHE timeout to default value. > > MFC after: 2 weeks > > Modified: > head/sys/cam/scsi/scsi_da.c > > Modified: head/sys/cam/scsi/scsi_da.c > ============================================================================== > --- head/sys/cam/scsi/scsi_da.c Mon Oct 17 08:29:16 2016 (r307506) > +++ head/sys/cam/scsi/scsi_da.c Mon Oct 17 08:35:56 2016 (r307507) > @@ -1488,12 +1488,11 @@ daclose(struct disk *dp) > scsi_synchronize_cache(&ccb->csio, /*retries*/1, > /*cbfcnp*/dadone, MSG_SIMPLE_Q_TAG, > /*begin_lba*/0, /*lb_count*/0, SSD_FULL_SIZE, > - 5 * 60 * 1000); > + da_default_timeout * 1000); > error = cam_periph_runccb(ccb, daerror, /*cam_flags*/0, > /*sense_flags*/SF_RETRY_UA | SF_QUIET_IR, > softc->disk->d_devstat); > - if (error == 0) > - softc->flags &= ~DA_FLAG_DIRTY; > + softc->flags &= ~DA_FLAG_DIRTY; > xpt_release_ccb(ccb); > } > >