From owner-freebsd-sysinstall@freebsd.org Fri Nov 25 22:50:00 2016 Return-Path: Delivered-To: freebsd-sysinstall@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D41CC54342 for ; Fri, 25 Nov 2016 22:50:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 13702152 for ; Fri, 25 Nov 2016 22:50:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uAPMnxpm030284 for ; Fri, 25 Nov 2016 22:49:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-sysinstall@FreeBSD.org Subject: [Bug 202058] bsdinstall - Disable dialog(3) for distfetch/checksum/distextract targets Date: Fri, 25 Nov 2016 22:49:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dteske@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-sysinstall@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 22:50:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202058 --- Comment #7 from Devin Teske --- I recommend the following: For C code, we should be using isatty(3) on stdout (fd=3D1) to determine wh= ether we use dialog(3) vs printf(3). For shell code, we should be using stty(1) to determine whether we use dialog(1) vs f_err()/printf(1). It doesn't make sense to use dialog(1,3) when stdout is not a TTY, so the c= ode should dynamically detect this situation and adjust accordingly (no need for setting a variable). For distfetch, distextract, and cksum, your printf's are good-to-go, but the conditional should be something like "if (notty)" which would be set when isatty(3) tells us that fd=3D1 is not a TTY. For bsdconfig, I would like to teach /usr/share/bsdconfig/dialog.subr to te= st for TTY on include (e.g., ``stty >&- 2>&- || setvar $VAR_NOTTY 1''*) and if set, dialog.subr would use f_err()/printf(1) instead of dialog(1). Then all= the other code could rely on f_dialog_* without having to address each invocati= on. It would be rather slick if we allowed the environment to override the defa= ult interpretation. That is to explain: If fd=3D1 is not a TTY (in C) or stty(1) reports error (in sh), default to = using printf(1,3). An environment variable (I suggest $noTty, $VAR_NOTTY), if set= and non-NULL overrides the default setting. In fact, if set, don't even perform= the isatty(3)/stty(1) test. * in /usr/share/bsdconfig/variable.subr we would add a "f_variable_new VAR_NOTTY noTty" --=20 You are receiving this mail because: You are the assignee for the bug.=