From owner-svn-src-all@freebsd.org Thu Aug 23 21:46:53 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00B531099560; Thu, 23 Aug 2018 21:46:53 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 73F3A89C4E; Thu, 23 Aug 2018 21:46:52 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id q5-v6so2320870iop.3; Thu, 23 Aug 2018 14:46:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=+lskxFjc5XAgvTdctdl3cHWcyFRlZQMgE/r4swcWbEw=; b=ekMBxDsJ8HIqobhnzy2Txbu4RCLYTKQtq2RQkoqZA7hLYbYcuZ1hAfL/G4nxh2vt/c SvNu4mtCHqsy5Uvh9QFnnWhdnPAB+M2GVzAE0oqcwww+TXuK3b645PNgN+Y78l2lS445 Oc7ojKe9z8/v9EGt5gyRJkX88k05isjNdRHoSfjSlWpjmmgFe16Aizk6uhiunCvDelBL /HaAG3NGFHUmakI4murS5Cs0ODBWzGTzFCkW78dPuBcEFwLpch4rjBztTaoUcHbnXLxD T03uIWbmyxMh+5QnpOkEU238bhTS7vTg6l/9TxSAej4JNnhZx5f+SXDelvks4JpRPuqF RBqQ== X-Gm-Message-State: AOUpUlEmmJTABcxZtIJST3yjXsQPl88ObdvG2An95AsBrW2hACjMhbEw OVf6aGxfEg8GbhdMxKpKY48jbdHJ X-Google-Smtp-Source: AA+uWPzcHXNVHFEECRTx1nKh65RPhLNOEd7oBXOz2oOCYhVO6utDqKlBnqgq3Dl6xxrCiOO7PG1+wQ== X-Received: by 2002:a6b:fa17:: with SMTP id p23-v6mr43608743ioh.101.1535060436067; Thu, 23 Aug 2018 14:40:36 -0700 (PDT) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com. [209.85.214.51]) by smtp.gmail.com with ESMTPSA id n198-v6sm2626139itn.36.2018.08.23.14.40.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Aug 2018 14:40:35 -0700 (PDT) Received: by mail-it0-f51.google.com with SMTP id 139-v6so9552965itf.0; Thu, 23 Aug 2018 14:40:35 -0700 (PDT) X-Received: by 2002:a24:db09:: with SMTP id c9-v6mr45298itg.92.1535060435620; Thu, 23 Aug 2018 14:40:35 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:b472:0:0:0:0:0 with HTTP; Thu, 23 Aug 2018 14:40:35 -0700 (PDT) In-Reply-To: <201808231819.w7NIJXDG072054@repo.freebsd.org> References: <201808231819.w7NIJXDG072054@repo.freebsd.org> From: Conrad Meyer Date: Thu, 23 Aug 2018 14:40:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r338270 - head/lib/libmd To: Alex Richardson Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 21:46:53 -0000 On Thu, Aug 23, 2018 at 11:19 AM, Alex Richardson wrote: > Author: arichardson > Date: Thu Aug 23 18:19:33 2018 > New Revision: 338270 > URL: https://svnweb.freebsd.org/changeset/base/338270 > > Log: > Don't build skein_block_asm.s if we don't have an as binary >... > It might also be better to just > compile the C file in userspace since the compiler can the use SSE/AVX. FYI, in my (limited) testing, the hand-written assembly has something like 50% performance advantage over the reference C implementation, even with -march=native, etc. Using the reference C version is totally fine for bootstrapping, but the compiler is not yet smart enough to write the assembler versions. Best, Conrad