From owner-freebsd-hackers@freebsd.org Fri May 15 15:57:26 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F0C922F8F68 for ; Fri, 15 May 2020 15:57:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49NtMp4f9fz42Qx for ; Fri, 15 May 2020 15:57:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 9F6212F8F65; Fri, 15 May 2020 15:57:26 +0000 (UTC) Delivered-To: hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F2632F8F64 for ; Fri, 15 May 2020 15:57:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49NtMm6ndBz42Qw for ; Fri, 15 May 2020 15:57:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id s1so3004861qkf.9 for ; Fri, 15 May 2020 08:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HFVsw8xrDbCjCjBYoo05RlgaBUbn9FgcTIAV2OIKs54=; b=JoPiXNFZKp9gLa8oZvkHl8UAxZwdWBugiJn7GhRkpF9impORES8zSmj/PkRccCRqcq SZ9ZxxtAJ3Qll8Bayt+U7Z4kKV5gEuCSCbrHZwefebsisaOL8C7jBDJR2aIYhitvUksM 8y9U1hMc5YzHUQsplNI6SRxPT8fql3u9qI8maegpOojj332JmLuVC4TktsTXR9pgLHwy 4S1rI0ZDYWZ60D5YGVt35TtMpXGXyu+cKwTJqOO2y3U5Q2ioFEm/Yy2EaG0FlfFm/o6p gtGhFUVEcByUWJqhKdsFnChvi/kL9OxIp+GDsu9lY7FEZWcef95hUlYGZm0Y9N4ne0s3 5cVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HFVsw8xrDbCjCjBYoo05RlgaBUbn9FgcTIAV2OIKs54=; b=FaaGujjPpUQFixcCHmjbvd0wE2o5qDAXQON02IE66rnm63N+Hp2Nc/1rQH8O6CZtNb nVyFGF8NcTYwhwdQXkevqVsof+QvgqOKVEhO14fJ8J1QiotuKWdZbYoJrFJKTKeW3qBe Ym/VI4aSMOz6HI5qd08Z5nVrXo0M0ySzENCZ9k5anYXZzDecCAiw92sTHzD9/BKxV2GH PF/AFnEwb5FNuTmIJ01GykCVfuCOaygxbfKwJ3UESy27OatL6nahHChA8ZSefW6Cg0wA vFnLoA3eWQMXAcuTQgEJXJv9Xnm5jWgRZg6WJ4gttJAaXP6IrEXTycwkzMMuPUh9N6+t 6iRg== X-Gm-Message-State: AOAM532HoCdRqw1fRGOOLxQYZEIVSGMthqL+Nhmi35wiSER+yQqxPzPH uM3Nn65n0RkU3gPJ5hOJtYP5RHy0Jo+r6ZrScQNzRQ== X-Google-Smtp-Source: ABdhPJzZfy7QIXi9UWVLT4yCy0VkHE/1gD4q0Bu/z3AE0bKs+3VejTmRM6fOFG0gAFv/Cf74IklClk/3fUMU1OKt45s= X-Received: by 2002:a05:620a:5bc:: with SMTP id q28mr4101296qkq.60.1589558243731; Fri, 15 May 2020 08:57:23 -0700 (PDT) MIME-Version: 1.0 References: <202005151504.04FF423p040952@fire.js.berklix.net> In-Reply-To: <202005151504.04FF423p040952@fire.js.berklix.net> From: Warner Losh Date: Fri, 15 May 2020 09:57:12 -0600 Message-ID: Subject: Re: [HEADSUP] Disallowing read() of a directory fd To: "Julian H. Stacey" Cc: "freebsd-arch@freebsd.org" , "freebsd-hackers@freebsd.org" , Kyle Evans , Poul-Henning Kamp , Alan Somers , Arne Steinkamm X-Rspamd-Queue-Id: 49NtMm6ndBz42Qw X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=JoPiXNFZ; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::729) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.96 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-1.96)[ip: (-9.01), ipnet: 2607:f8b0::/32(-0.33), asn: 15169(-0.42), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 15:57:27 -0000 On Fri, May 15, 2020 at 9:04 AM Julian H. Stacey wrote: > kevans@ wasted FreeBSD time with threat of change at 2 days notice, > for an issue unchanged since 1972. The rush was immature. > > kevans@ should retract his threat of forced urgent change, or expect > core@ be asked to remove his commit bit while FreeBSD considers > _un-rushed_, allowing sufficient time for all to consider options, > & to warn users in RELNOTES of any potential future change. > Threats are not tolerated in this project. This hyperbolic response has gone on long enough. Please stop and treat your fellow committers with respect and a certain level of professionalism. He's done none of the nefarious things you've said (I've known about this changes for days if not weeks as he socialized it, for example). He doesn't deserve this level of grief over a proposal. It's a request for comments, not a request for abuse and nasty behaviour. This whole thread has gone toxic / hyperbolic over a non-issue. You should have stopped reading directories in 1983 when readdir was introduced because UFS broke ls, find, du, etc. At best, it's a nice debugging tool some folks don't want to lose. At worst, it causes bugs for programs that accidentally read directories (and maybe some, like grep, need some minor changes). It's not worth this much bile and venom. Warner