From owner-svn-src-projects@FreeBSD.ORG Thu Aug 25 17:05:55 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D96B41065670; Thu, 25 Aug 2011 17:05:55 +0000 (UTC) (envelope-from mdf@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C9CA78FC13; Thu, 25 Aug 2011 17:05:55 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p7PH5trd011895; Thu, 25 Aug 2011 17:05:55 GMT (envelope-from mdf@svn.freebsd.org) Received: (from mdf@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p7PH5tE6011893; Thu, 25 Aug 2011 17:05:55 GMT (envelope-from mdf@svn.freebsd.org) Message-Id: <201108251705.p7PH5tE6011893@svn.freebsd.org> From: Matthew D Fleming Date: Thu, 25 Aug 2011 17:05:55 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r225178 - projects/ino64/lib/libc/gen X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2011 17:05:55 -0000 Author: mdf Date: Thu Aug 25 17:05:55 2011 New Revision: 225178 URL: http://svn.freebsd.org/changeset/base/225178 Log: Segfault on bad input like the original, as no callers are checking the return code. Requested by: Jilles Tjoelker Modified: projects/ino64/lib/libc/gen/dirfd.c Modified: projects/ino64/lib/libc/gen/dirfd.c ============================================================================== --- projects/ino64/lib/libc/gen/dirfd.c Thu Aug 25 15:51:54 2011 (r225177) +++ projects/ino64/lib/libc/gen/dirfd.c Thu Aug 25 17:05:55 2011 (r225178) @@ -43,8 +43,6 @@ __FBSDID("$FreeBSD$"); int dirfd(DIR *dirp) { - if (dirp == NULL) - return (-1); return (_dirfd(dirp)); }