Date: Mon, 14 Feb 2005 01:51:22 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: freebsd-arch@freebsd.org Subject: Re: buildenv target Message-ID: <20050213235122.GB15825@ip.net.ua> In-Reply-To: <20050213231105.GC40468@funkthat.com> References: <20050213001752.GA40468@funkthat.com> <21203.1108255197@critter.freebsd.dk> <20050213093700.GF88292@ip.net.ua> <20050213231105.GC40468@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sun, Feb 13, 2005 at 03:11:05PM -0800, John-Mark Gurney wrote:
> Ruslan Ermilov wrote this message on Sun, Feb 13, 2005 at 11:37 +0200:
> > Hi John-Mark,
> >
> > On Sun, Feb 13, 2005 at 01:39:57AM +0100, Poul-Henning Kamp wrote:
> > > Sounds like a good addition.
> >
> > I missed the original post, so replying here. I very much like
> > and support the idea. About the implementation, for the standard
> > case of root doing this, the standard ~root/.cshrc unfortunately
> > resets PATH, making this useless pretty useless. So I suggest
> > to use "sh" here. Another minor buglet is that the output for
> > pc98 will be mangled, "pc98:i386". Here's my version, simplified
> > and fixed:
> >
> > %%%
> > Index: Makefile.inc1
> > ===================================================================
> > RCS file: /home/ncvs/src/Makefile.inc1,v
> > retrieving revision 1.473
> > diff -u -p -r1.473 Makefile.inc1
> > --- Makefile.inc1 20 Jan 2005 10:49:02 -0000 1.473
> > +++ Makefile.inc1 13 Feb 2005 01:20:00 -0000
> > @@ -457,6 +457,10 @@ WMAKE_TGTS+= build32
> > buildworld: ${WMAKE_TGTS}
> > .ORDER: ${WMAKE_TGTS}
> >
> > +buildenv:
> > + @echo Entering world for ${TARGET_ARCH}:${TARGET}
> > + @${WMAKEENV} sh || true
> > +
> > TOOLCHAIN_TGTS= ${WMAKE_TGTS:N_depend:Neverything}
> > toolchain: ${TOOLCHAIN_TGTS}
> > kernel-toolchain: ${TOOLCHAIN_TGTS:N_includes:N_libraries}
>
> Hmmm.. wierd, I thought I tried this, but I kept getting i386, but
> I just tried it here, and works fine...
>
This is probably because you tried MACHINE_ARCH/MACHINE.
> Unless you object, I'll use
> /bin/sh and /usr/bin/true, just incase the path is a bit messed up..
>
No need to; src/Makefile already takes care of always setting up
the correct PATH, try it with "make -n buildenv".
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFCD+f6qRfpzJluFF4RAjEBAJ4ia8+GtQY79TLnK5Vzarzw3T5AawCfSJmR
v95bYcc+dady42l6WncrO4o=
=faVT
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050213235122.GB15825>