Date: Sat, 6 Sep 1997 14:49:59 -0700 From: John-Mark Gurney <gurney_j@efn.org> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: multimedia@FreeBSD.ORG Subject: Re: snd970904.tgz Message-ID: <19970906144959.33770@hydrogen.nike.efn.org> In-Reply-To: <199709061959.VAA13866@labinfo.iet.unipi.it>; from Luigi Rizzo on Sat, Sep 06, 1997 at 09:59:57PM %2B0200 References: <19970906135343.02473@hydrogen.nike.efn.org> <199709061959.VAA13866@labinfo.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo scribbled this message on Sep 6: > > > do you have patches/sources ? Please submit a PR so that it gets fixed. > > > > well.. I was thinking of commiting 'em soon.. they work nicely over > > do you have commit privs ? I am looking for someone to do the commit of > this sound code to 3.0, and of pnp code to 3.0 and 2.2 -- and it would > be better if it is someone familiar with the code so he knows what the > code does and can debug things. Contact Jordan if you are in this > position and willing to do the commit. yes I do... I'll send a message off to Jordan in a bit... > > well... I looked at the code briefly... and notice that in mss_open > > you set the flag on the device for what it trying to open, and then > > you test to see if the card is busy... then if the card is busy, you > > just leave without clearing the flag... I'm not sure if this would > > cause the bug or not... (ad1848.c:274)... > > I don't think so, since multiple opens are allowed, they just don't let > you reinitialize the device if someone else is active. Also the error > message you got seemed to indicate that I forgot SND_F_READING set... > If you happen to find this problem again, either with the kernel > debugger or with the small program "test.c" (in the misc/ subdirectory, > it mmaps the descriptor so you can look at it) try to find out the > status of flags. well.. if you can tell me what symbols I need to look at... I have a core dump of the system in the broken state... I had the numbers from test.c but the machine crashed while I was writing the message... I think the flags for reading was something like 0x20009000... I'm not sure were the 9 was though... > > my other comment is the in sndopen (sound.c:366) that you first clear > > out the pid and flags info from the data struct that you got even before > > checking that the actual open successeds... I'm not sure if this is a > > problem or not.. but it just struck me as being out of place... > > yes it was. In fact, the select data structures must be initialized > only if the device is not currently busy (could be done in sound.c, or > in the device-specific routine), and _not_ when opening the mixer. Have > put these in the device-specific code now. well.. I'll be looking forward to your next snap.. :) ttyl... -- John-Mark Gurney Modem/FAX: +1 541 683 6954 Cu Networking Live in Peace, destroy Micro$oft, support free software, run FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970906144959.33770>