From owner-svn-src-head@freebsd.org  Mon Oct 16 09:26:06 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64F79E3466E;
 Mon, 16 Oct 2017 09:26:06 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16])
 by mx1.freebsd.org (Postfix) with ESMTP id 19BF774411;
 Mon, 16 Oct 2017 09:26:05 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from [IPv6:2a02:c7f:1e13:cf00:496b:675f:1417:d64b] (unknown
 [IPv6:2a02:c7f:1e13:cf00:496b:675f:1417:d64b])
 by fry.fubar.geek.nz (Postfix) with ESMTPSA id D71A34ECB2;
 Mon, 16 Oct 2017 09:19:32 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader
From: Andrew Turner <andrew@fubar.geek.nz>
In-Reply-To: <201710160359.v9G3xCCi087576@repo.freebsd.org>
Date: Mon, 16 Oct 2017 10:19:30 +0100
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C5C51AA5-F439-4B38-8FCF-0AA3C1FF7E34@fubar.geek.nz>
References: <201710160359.v9G3xCCi087576@repo.freebsd.org>
To: Warner Losh <imp@FreeBSD.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 09:26:06 -0000


> On 16 Oct 2017, at 04:59, Warner Losh <imp@FreeBSD.org> wrote:
>=20
> Author: imp
> Date: Mon Oct 16 03:59:11 2017
> New Revision: 324646
> URL: https://svnweb.freebsd.org/changeset/base/324646
>=20
> Log:
>  Unify boot1 with loader
>=20
>  Refactor boot1 to use the same I/O code as /boot/loader uses. =
Refactor
>  to use the common efi_main.c.
>=20
>  Submitted by: Eric McCorkle
>  Differential Revision: https://reviews.freebsd.org/D10447
>=20
> Added:
>  head/sys/boot/efi/libefi/efi_main.c   (contents, props changed)
>     - copied, changed from r324645, =
head/sys/boot/efi/loader/efi_main.c
> Deleted:
>  head/sys/boot/efi/boot1/boot_module.h
>  head/sys/boot/efi/boot1/ufs_module.c
>  head/sys/boot/efi/boot1/zfs_module.c
>  head/sys/boot/efi/loader/efi_main.c
> Modified:
>  head/sys/boot/efi/boot1/Makefile
>  head/sys/boot/efi/boot1/boot1.c
>  head/sys/boot/efi/libefi/Makefile
>  head/sys/boot/efi/loader/Makefile

Hello Warner,

After this change I=E2=80=99m getting the following panic on various =
test VMs.

Andrew

>> FreeBSD EFI boot block

   Loader path: /boot/loader.efi

   Load Path: \EFI\BOOT\BOOTAA64.EFI
   Load Device: =
VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003C000A00000000)/HD(1,GPT,DD40=
E9C6-B247-11E7-AA0A-15EFE1BBB7CF,0x3,0x640)
panic: Couldn't trim device path
--> Press a key on the console to reboot <--