From owner-freebsd-audit  Tue Mar 18  1:55:13 2003
Delivered-To: freebsd-audit@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 987FB37B401
	for <audit@freebsd.org>; Tue, 18 Mar 2003 01:55:12 -0800 (PST)
Received: from gvr.gvr.org (gvr.gvr.org [212.61.40.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 37EC543FB1
	for <audit@freebsd.org>; Tue, 18 Mar 2003 01:55:11 -0800 (PST)
	(envelope-from guido@gvr.org)
Received: by gvr.gvr.org (Postfix, from userid 657)
	id 843521A; Tue, 18 Mar 2003 10:55:09 +0100 (CET)
Date: Tue, 18 Mar 2003 10:55:09 +0100
From: Guido van Rooij <guido@gvr.org>
To: Guy Helmer <ghelmer@palisadesys.com>
Cc: audit@freebsd.org
Subject: Re: /bin/sh flag NO_HISTORY
Message-ID: <20030318095509.GA70239@gvr.gvr.org>
References: <FPEBKMIFGFHCGLLKBLMMCENKCBAA.ghelmer@palisadesys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <FPEBKMIFGFHCGLLKBLMMCENKCBAA.ghelmer@palisadesys.com>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Mon, Mar 17, 2003 at 02:11:53PM -0600, Guy Helmer wrote:
> --- /usr/src/bin/sh/Makefile	Mon Mar 17 10:38:03 2003
> +++ Makefile	Mon Mar 17 10:34:07 2003
> @@ -14,8 +14,12 @@
>  # utilities of the same name are handled with the associated manpage,
>  # builtin.1 in share/man/man1/.
> 
> +.if !defined(NO_HISTORY)
>  DPADD+= ${LIBL} ${LIBEDIT} ${LIBTERMCAP}
>  LDADD+= -ll -ledit -ltermcap
> +.else
> +CFLAGS+=-DNO_HISTORY
> +.endif

Could you please do this the other way around:
.if defined(NO_HISTORY)
CFLAGS+=-DNO_HISTORY
.else
DPADD+= ${LIBL} ${LIBEDIT} ${LIBTERMCAP}
LDADD+= -ll -ledit -ltermcap
.endif

I think double negations don't add in readbility.

-Guido

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message