From owner-svn-src-head@freebsd.org Wed Sep 26 19:26:50 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD9A810B4A44 for ; Wed, 26 Sep 2018 19:26:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 362E28B592 for ; Wed, 26 Sep 2018 19:26:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io1-xd33.google.com with SMTP id u12-v6so60311ioc.11 for ; Wed, 26 Sep 2018 12:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zU22pvjW5muF7gs/Uw+pBRJf8WoWubREpgoN/lzImYo=; b=uUqW37kuZhReARMktpW3DsTj9iskZS77c3sfLPZNlycXudzNvOnmPGDj0otp3c4E5v viQxvI+yt2Snp+wtc4/PrsCqVzMaXtmR0iK6rLqVIrPlvU5DCsyThms5aDQSa6a5t30m Dmn/KhrOFsukg3rAlWVUvMzruG2DuYDf8cdKmP+KU/vh+/x5ylcZzAdxizihJULiO2Jl +sCGYk/OSsn1/X5LefwGocM8ZoM+5lPZpK5WhAAUP3G7I38hWuTN+yvwrP45Cj02aiES 657eEN6oTHAY5CfyrcC3bXbn9AnNOGw0s/6Z8gDGfs0IJ/fxfIpE62OPksnGqL3LY/oP 5H+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zU22pvjW5muF7gs/Uw+pBRJf8WoWubREpgoN/lzImYo=; b=FtpIzBOjJu6KYfDEQQl8wcFKTf0APvEX6iVfORzFddkdvkTUJ5qPr5O+dXCR4RT/gz rIgPEw/NW/Xm9e0rnDQufydME6gg4HC/22oOCA19yw3ORciqs05S1vCSAc3thJ19NTZZ z34d78R1rnaUmQtFPvm+azPgTePRMPytnhIz4+U8n5XXYcRmcj7hCRS7Q0bTx073m3Z2 vUwk3fW56GGWTDzrP2wTN4LBOW03gpyiQlE4iL6LWrCW/zaiOELT0yB6Hm88F3luaRkG EwvUzdYm/bxlFCvWp7Kb8584UA7BSFd2aecSILIEBCLNeiE1I8h8jK0PueLZv01drhjj 2AAg== X-Gm-Message-State: ABuFfogYNPcUk2VjC72FWTZrfK0Mly4o3TifAozN7hMN4aupKWEzhY7Y GaVid8yVvLiFDXod/IVr0FMxW0i+3NP8bFLOu1+e6w== X-Google-Smtp-Source: ACcGV61pJHkNcXQ0/OhYfGCRif/V4vupOfxGWe5VwTD6aZu5UdNRY0to5Z3ukCKAtmPX7vp5I2g4Ik/2c5swql3ue84= X-Received: by 2002:a6b:3902:: with SMTP id g2-v6mr6369111ioa.168.1537990009401; Wed, 26 Sep 2018 12:26:49 -0700 (PDT) MIME-Version: 1.0 References: <201809261712.w8QHCV1q094153@repo.freebsd.org> <800a97c9-595c-6621-fd58-fc9dae1a17dd@FreeBSD.org> In-Reply-To: <800a97c9-595c-6621-fd58-fc9dae1a17dd@FreeBSD.org> From: Warner Losh Date: Wed, 26 Sep 2018 13:26:38 -0600 Message-ID: Subject: Re: svn commit: r338949 - in head/sys/dev: cxgb ida iwn ixl mfi mpr mps mvs my oce pccbb pcn ral rl To: Navdeep Parhar Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 19:26:50 -0000 Yea, I have a fix submitted to re@. It looks like I as I was moving the changes between trees that one of the changes to fix this got dropped. :( Warner On Wed, Sep 26, 2018 at 1:13 PM Navdeep Parhar wrote: > This seems to break installkernel. kldxref works if I back out this > change. > > kldxref /boot/head > kldxref: Parse error of description string U16:vendor; U16:device > > Regards, > Navdeep > > On 9/26/18 10:12 AM, Warner Losh wrote: > > Author: imp > > Date: Wed Sep 26 17:12:30 2018 > > New Revision: 338949 > > URL: https://svnweb.freebsd.org/changeset/base/338949 > > > > Log: > > Add PNP info to PCI attachments of cbb, cxgb, ida, iwn, ixl, ixlv, > > mfi, mps, mpr, mvs, my, oce, pcn, ral, rl. This only labels existing > > pci device tables, and has no probe / attach code changes. > > > > Reviewed by: imp, chuck > > Submitted by: Lakhan Shiva Kamireddy > > Sponsored by: Google, Inc. (GSoC 2018) > > Approved by: re (glen) > > > > Modified: > > head/sys/dev/cxgb/cxgb_main.c > > head/sys/dev/ida/ida_pci.c > > head/sys/dev/iwn/if_iwn.c > > head/sys/dev/ixl/if_ixl.c > > head/sys/dev/ixl/if_ixlv.c > > head/sys/dev/mfi/mfi_pci.c > > head/sys/dev/mpr/mpr_pci.c > > head/sys/dev/mps/mps_pci.c > > head/sys/dev/mvs/mvs_pci.c > > head/sys/dev/my/if_my.c > > head/sys/dev/oce/oce_if.c > > head/sys/dev/pccbb/pccbb_pci.c > > head/sys/dev/pcn/if_pcn.c > > head/sys/dev/ral/if_ral_pci.c > > head/sys/dev/rl/if_rl.c > > > ... >