Date: Wed, 21 Nov 2018 16:37:35 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r485521 - in head/lang: perl5-devel/files perl5.24/files perl5.26/files perl5.28/files Message-ID: <201811211637.wALGbZZm033954@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Wed Nov 21 16:37:34 2018 New Revision: 485521 URL: https://svnweb.freebsd.org/changeset/ports/485521 Log: Remove two unimportant failing tests. Added: head/lang/perl5-devel/files/patch-ext_GDBM__File_t_fatal.t (contents, props changed) head/lang/perl5.24/files/patch-ext_GDBM__File_t_fatal.t (contents, props changed) head/lang/perl5.26/files/patch-ext_GDBM__File_t_fatal.t (contents, props changed) head/lang/perl5.28/files/patch-ext_GDBM__File_t_fatal.t (contents, props changed) Added: head/lang/perl5-devel/files/patch-ext_GDBM__File_t_fatal.t ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lang/perl5-devel/files/patch-ext_GDBM__File_t_fatal.t Wed Nov 21 16:37:34 2018 (r485521) @@ -0,0 +1,30 @@ +Those two test fails starting with gdbm 1.15. + +--- ext/GDBM_File/t/fatal.t.orig 2018-11-21 14:08:44 UTC ++++ ext/GDBM_File/t/fatal.t +@@ -12,7 +12,7 @@ BEGIN { + plan(skip_all => "GDBM_File is flaky in $^O") + if $^O =~ /darwin/; + +- plan(tests => 8); ++ plan(tests => 6); + use_ok('GDBM_File'); + } + +@@ -34,16 +34,5 @@ isnt((open $fh, "<&=$fileno"), undef, "d + or diag("\$! = $!"); + isnt(close $fh, undef, + "close fileno $fileno, out from underneath the GDBM_File"); +-is(eval { +- $h{Perl} = 'Rules'; +- untie %h; +- 1; +-}, undef, 'Trapped error when attempting to write to knobbled GDBM_File'); +- +-# Observed "File write error" and "lseek error" from two different systems. +-# So there might be more variants. Important part was that we trapped the error +-# via croak. +-like($@, qr/ at .*\bfatal\.t line \d+\.\n\z/, +- 'expected error message from GDBM_File'); + + unlink <fatal_dbmx*>; Added: head/lang/perl5.24/files/patch-ext_GDBM__File_t_fatal.t ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lang/perl5.24/files/patch-ext_GDBM__File_t_fatal.t Wed Nov 21 16:37:34 2018 (r485521) @@ -0,0 +1,30 @@ +Those two test fails starting with gdbm 1.15. + +--- ext/GDBM_File/t/fatal.t.orig 2018-03-23 19:37:49 UTC ++++ ext/GDBM_File/t/fatal.t +@@ -12,7 +12,7 @@ BEGIN { + plan(skip_all => "GDBM_File is flaky in $^O") + if $^O =~ /darwin/; + +- plan(tests => 8); ++ plan(tests => 6); + use_ok('GDBM_File'); + } + +@@ -34,16 +34,5 @@ isnt((open $fh, "<&=$fileno"), undef, "d + or diag("\$! = $!"); + isnt(close $fh, undef, + "close fileno $fileno, out from underneath the GDBM_File"); +-is(eval { +- $h{Perl} = 'Rules'; +- untie %h; +- 1; +-}, undef, 'Trapped error when attempting to write to knobbled GDBM_File'); +- +-# Observed "File write error" and "lseek error" from two different systems. +-# So there might be more variants. Important part was that we trapped the error +-# via croak. +-like($@, qr/ at .*\bfatal\.t line \d+\.\n\z/, +- 'expected error message from GDBM_File'); + + unlink <Op_dbmx*>; Added: head/lang/perl5.26/files/patch-ext_GDBM__File_t_fatal.t ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lang/perl5.26/files/patch-ext_GDBM__File_t_fatal.t Wed Nov 21 16:37:34 2018 (r485521) @@ -0,0 +1,30 @@ +Those two test fails starting with gdbm 1.15. + +--- ext/GDBM_File/t/fatal.t.orig 2018-03-23 19:34:32 UTC ++++ ext/GDBM_File/t/fatal.t +@@ -12,7 +12,7 @@ BEGIN { + plan(skip_all => "GDBM_File is flaky in $^O") + if $^O =~ /darwin/; + +- plan(tests => 8); ++ plan(tests => 6); + use_ok('GDBM_File'); + } + +@@ -34,16 +34,5 @@ isnt((open $fh, "<&=$fileno"), undef, "d + or diag("\$! = $!"); + isnt(close $fh, undef, + "close fileno $fileno, out from underneath the GDBM_File"); +-is(eval { +- $h{Perl} = 'Rules'; +- untie %h; +- 1; +-}, undef, 'Trapped error when attempting to write to knobbled GDBM_File'); +- +-# Observed "File write error" and "lseek error" from two different systems. +-# So there might be more variants. Important part was that we trapped the error +-# via croak. +-like($@, qr/ at .*\bfatal\.t line \d+\.\n\z/, +- 'expected error message from GDBM_File'); + + unlink <Op_dbmx*>; Added: head/lang/perl5.28/files/patch-ext_GDBM__File_t_fatal.t ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lang/perl5.28/files/patch-ext_GDBM__File_t_fatal.t Wed Nov 21 16:37:34 2018 (r485521) @@ -0,0 +1,30 @@ +Those two test fails starting with gdbm 1.15. + +--- ext/GDBM_File/t/fatal.t.orig 2018-05-21 10:44:04 UTC ++++ ext/GDBM_File/t/fatal.t +@@ -12,7 +12,7 @@ BEGIN { + plan(skip_all => "GDBM_File is flaky in $^O") + if $^O =~ /darwin/; + +- plan(tests => 8); ++ plan(tests => 6); + use_ok('GDBM_File'); + } + +@@ -34,16 +34,5 @@ isnt((open $fh, "<&=$fileno"), undef, "d + or diag("\$! = $!"); + isnt(close $fh, undef, + "close fileno $fileno, out from underneath the GDBM_File"); +-is(eval { +- $h{Perl} = 'Rules'; +- untie %h; +- 1; +-}, undef, 'Trapped error when attempting to write to knobbled GDBM_File'); +- +-# Observed "File write error" and "lseek error" from two different systems. +-# So there might be more variants. Important part was that we trapped the error +-# via croak. +-like($@, qr/ at .*\bfatal\.t line \d+\.\n\z/, +- 'expected error message from GDBM_File'); + + unlink <Op_dbmx*>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811211637.wALGbZZm033954>