From owner-cvs-all@FreeBSD.ORG Fri Feb 25 13:37:38 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99D9816A4CE; Fri, 25 Feb 2005 13:37:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62FA643D7E; Fri, 25 Feb 2005 13:37:38 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j1PDbc87067097; Fri, 25 Feb 2005 13:37:38 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j1PDbcij067096; Fri, 25 Feb 2005 13:37:38 GMT (envelope-from rwatson) Message-Id: <200502251337.j1PDbcij067096@repoman.freebsd.org> From: Robert Watson Date: Fri, 25 Feb 2005 13:37:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/netipx spx_usrreq.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2005 13:37:38 -0000 rwatson 2005-02-25 13:37:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/netipx spx_usrreq.c Log: Merge spx_usrreq.c:1.60 from HEAD to RELENG_5: Clean up return handling for a number of SPX-related routines that were derived from more complex TCP versions of the same: - spx_close(), spx_disconnect(), spx_drop(), and spx_usrclosed() all always free's the spxpcb invalidating the argument, so a return value is not required to indicate if it has. - Annotate that the cb arguments to each of these functions is invalidated via a comment. - When tearing down a pcb due to sonewconn() having failed, mark the cb as NULL; later, when deciding whether to store trace information due to SO_DEBUG, check that cb is not NULL before dereferencing or a NULL pointer dereference may occur. Revision Changes Path 1.46.2.12 +28 -21 src/sys/netipx/spx_usrreq.c