From owner-cvs-all@FreeBSD.ORG  Sun Feb 24 01:09:51 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D356F16A404
	for <cvs-all@FreeBSD.org>; Sun, 24 Feb 2008 01:09:51 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 5D5C313C46B
	for <cvs-all@FreeBSD.org>; Sun, 24 Feb 2008 01:09:51 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: (qmail 83386 invoked from network); 24 Feb 2008 00:25:23 -0000
Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1])
	(envelope-sender <andre@freebsd.org>)
	by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
	for <cperciva@FreeBSD.org>; 24 Feb 2008 00:25:23 -0000
Message-ID: <47C0C3DF.1080700@freebsd.org>
Date: Sun, 24 Feb 2008 02:09:51 +0100
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Thunderbird 1.5.0.14 (Windows/20071210)
MIME-Version: 1.0
To: Colin Percival <cperciva@FreeBSD.org>
References: <200802240007.m1O071xr052282@repoman.freebsd.org>
In-Reply-To: <200802240007.m1O071xr052282@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Feb 2008 01:09:51 -0000

Colin Percival wrote:
> cperciva    2008-02-24 00:07:00 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             uipc_syscalls.c 
>   Log:
>   After finishing sending file data in sendfile(2), don't forget to send
>   the provided trailers.  This has been broken since revision 1.240.
>   
>   Submitted by:   Dan Nelson
>   PR:             kern/120948
>   "sounds ok to me" from: phk

It is correct.

>   MFC after:      3 days
>   
>   Revision  Changes    Path
>   1.269     +3 -1      src/sys/kern/uipc_syscalls.c

Pointy hat extra wide and extra long to /me for not having written a proper
regression program.  Mea culpa.  Shall happen never again.  The implementation
of kern_sendfile() is a damn complex beast.

-- 
Andre