Date: Fri, 6 Jul 2007 01:12:43 +0200 From: Dejan Lesjak <dejan.lesjak@ijs.si> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: x11@freebsd.org Subject: Re: Protecting post-install in xorg-libraries Message-ID: <0D9799A7-CF20-455F-93BB-DB9F5A9D18BE@ijs.si> In-Reply-To: <1183601036.2755.23.camel@shumai.marcuscom.com> References: <1183601036.2755.23.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 5, 2007, at 4:03 AM, Joe Marcus Clarke wrote:
> I don't think the pkg-install script for xorg-libraries should be run
> when PACKAGE_BUILDING is defined. This leaves left over etc/
> rc.conf and
> etc/periodic.conf, and doesn't buy anything if you are just building
> packages.
>
> The post-install target should probably look like:
>
> .if !defined(PACKAGE_BUILDING)
> post-install:
> @${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
> .endif
Indeed. Committed, thanks!
Builds of some packages will still report changed files in
environment like Tinderbox though as they install the package version
of xorg-libraries. The two files should be ignored there the same as /
usr/X11R6 symlink (kris already said pointyhat will ignore them).
Sorry for not mentioning this for Tinderbox earlier.
Dejan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0D9799A7-CF20-455F-93BB-DB9F5A9D18BE>