From nobody Mon Nov 17 17:00:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d9DXl3F09z6GYg3; Mon, 17 Nov 2025 17:01:11 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp5.goneo.de [IPv6:2001:1640:5::8:30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4d9DXl0f4Zz3XcX; Mon, 17 Nov 2025 17:01:10 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub2.goneo.de (hub2.goneo.de [85.220.129.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id E0256240ACA; Mon, 17 Nov 2025 18:01:02 +0100 (CET) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id 03ED1240542; Mon, 17 Nov 2025 18:01:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1763398861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3tPPxw88G4TLwlmCovgPLK6lA+CusYoLwTdeHy7/xTY=; b=llP3Tpi7zU1ZMhLS7/jIvZ3Dq+ixHvhA4K9uyN2NWhZw/qMjGDHUaVqeGM33Qc+KjuFhII QRXO+XOaEPqBLzlvDT1iHvYDdLLvC5SelPq0VREMi9P/DsPPH/X6PJc4tVCefvX4e4VzM1 UEP7IqJOVkcMWS9Gfj2y63rP3ujAVRG3BkpwQSRSosl5epJZ0VwhHl1Ohy5m75y3pEWOcv wLI33/8ezcWtNPIjsyx+7ZX1Yqcwe7QcBU5kNIbK+j1GfIz2T8jC59MRJzixAaOI8Ym4Qu wO/u70D63q426fzTJZU4Ls7ZuqL8Lf6bijFPP1ilLWwAK9n2CD5LeM0/5KytuQ== Received: from thor.sb211.local (dynamic-2a02-3100-2ea1-7002-7587-9c98-e11e-6c68.310.pool.telefonica.de [IPv6:2a02:3100:2ea1:7002:7587:9c98:e11e:6c68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id 7D39424021E; Mon, 17 Nov 2025 18:01:00 +0100 (CET) Date: Mon, 17 Nov 2025 18:00:26 +0100 From: A FreeBSD User To: Warner Losh Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 44fb9f2701c7 - main - sys/efi_map.h: This is a kernel-only file Message-ID: <20251117180053.03f95e7a@thor.sb211.local> In-Reply-To: References: <202511170018.5AH0ITWK063891@gitrepo.freebsd.org> <20251117051144.3d0c31d9@thor.sb211.local> X-Mailer: Claws Mail 3.21.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/TlOH9YXa5uMGJ4f6CzYkjgH"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Rspamd-UID: be517f X-Rspamd-UID: bf10ac X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4d9DXl0f4Zz3XcX --Sig_/TlOH9YXa5uMGJ4f6CzYkjgH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Tage des Herren Sun, 16 Nov 2025 23:05:08 -0700 Warner Losh schrieb: > On Sun, Nov 16, 2025 at 10:16=E2=80=AFPM Warner Losh wro= te: >=20 > > > > > > On Sun, Nov 16, 2025 at 9:14=E2=80=AFPM A FreeBSD User > > wrote: > > =20 > >> Am Tage des Herren Mon, 17 Nov 2025 00:18:29 GMT > >> Warner Losh schrieb: > >> =20 > >> > The branch main has been updated by imp: > >> > > >> > URL: =20 > >> https://cgit.FreeBSD.org/src/commit/?id=3D44fb9f2701c71ce6bba75810fc6b= 7e735ecd5868 =20 > >> > > >> > commit 44fb9f2701c71ce6bba75810fc6b7e735ecd5868 > >> > Author: Warner Losh > >> > AuthorDate: 2025-11-16 23:58:37 +0000 > >> > Commit: Warner Losh > >> > CommitDate: 2025-11-17 00:16:26 +0000 > >> > > >> > sys/efi_map.h: This is a kernel-only file > >> > > >> > Slap a #ifdef _KERNEL around it all since it's useless to userla= nd. > >> > > >> > Fixes: 43b8edb32051 > >> > Sponsored by: Netflix > >> > --- > >> > sys/sys/efi_map.h | 4 ++++ > >> > 1 file changed, 4 insertions(+) > >> > > >> > diff --git a/sys/sys/efi_map.h b/sys/sys/efi_map.h > >> > index 8b458cd08b00..d2206056b1f8 100644 > >> > --- a/sys/sys/efi_map.h > >> > +++ b/sys/sys/efi_map.h > >> > @@ -7,6 +7,8 @@ > >> > #ifndef _SYS_EFI_MAP_H_ > >> > #define _SYS_EFI_MAP_H_ > >> > > >> > +#ifdef _KERNEL > >> > + > >> > #include > >> > #include > >> > > >> > @@ -21,4 +23,6 @@ void efi_map_add_entries(struct efi_map_header =20 > >> *efihdr); =20 > >> > void efi_map_exclude_entries(struct efi_map_header *efihdr); > >> > void efi_map_print_entries(struct efi_map_header *efihdr); > >> > > >> > +#endif > >> > + > >> > #endif /* !_SYS_EFI_MAP_H_ */ > >> > =20 > >> > >> Hello, > >> > >> tried a buildworld just now and it fails, something seems missing: > >> > >> [...] =20 > >> =3D=3D=3D> stand/libsa (all) =20 > >> mkdir -p xlocale arpa ssp; for i in a.out.h assert.h elf.h limits.h > >> nlist.h setjmp.h stddef.h > >> stdbool.h string.h strings.h time.h uuid.h; do ln -sf > >> /usr/src/include/$i $i; done; ln -sf > >> /usr/src/sys/sys/errno.h errno.h; ln -sf /usr/src/sys/sys/stdarg.h > >> stdarg.h; ln -sf > >> /usr/src/sys/sys/stdint.h stdint.h; ln -sf /usr/src/include/arpa/inet= .h > >> arpa/inet.h; ln -sf > >> /usr/src/include/arpa/tftp.h arpa/tftp.h; ln -sf > >> /usr/src/include/ssp/ssp.h ssp/ssp.h; for i in _time.h _strings.h > >> _string.h; do [ -f xlocale/$i ] || :> > >> xlocale/$i; done; for i in ctype.h fcntl.h signal.h stdio.h stdlib.h > >> unistd.h; do ln -sf > >> /usr/src/stand/libsa/stand.h $i; done cc -target > >> x86_64-unknown-freebsd16.0 > >> --sysroot=3D/usr/obj/usr/src/amd64.amd64/tmp > >> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 > >> -pipe -fno-common -nostdinc > >> -I/usr/obj/usr/src/amd64.amd64/stand/libsa > >> -I/usr/src/stand/libsa -D_STANDALONE -I/usr/src/sys > >> -Ddouble=3Djagged-little-pill > >> -Dfloat=3Dfloaty-mcfloatface -ffunction-sections -fdata-sections > >> -DLOADER_GELI_SUPPORT > >> -I/usr/src/stand/libsa/geli -DLOADER_DISK_SUPPORT -ffreestanding -mno-= mmx > >> -mno-sse -mno-avx > >> -mno-avx2 -msoft-float -fPIC -mno-red-zone -mno-relax -I. > >> -DLOADER_VERIEXEC > >> -I/usr/src/lib/libsecureboot/h -DLOADER_VERIEXEC_VECTX -Iinclude > >> -I/usr/src/contrib/bearssl/inc -Wno-deprecated-non-prototype > >> -I/usr/src/contrib/bearssl/src > >> -I/usr/src/lib/libsecureboot/h -DHAVE_BR_X509_TIME_CHECK -DNO_STDIO > >> -I/usr/src/contrib/bearssl/tools -I. -DTRUST_ANCHOR_STR=3Dta_PEM > >> -DVE_SHA256_SUPPORT > >> -DVE_SHA384_SUPPORT -DVE_RSA_SUPPORT -DVE_PCR_SUPPORT > >> -I/usr/src/stand/efi/include > >> -I/usr/src/lib/libsecureboot/efi/include > >> -I/usr/src/stand/efi/include/amd64 -DNDEBUG -MD > >> -MF.depend.efi_variables.o -MTefi_variables.o -std=3Dgnu17 > >> -Wno-format-zero-length > >> -Wsystem-headers -Wno-pointer-sign -Wdate-time -Wno-empty-body > >> -Wno-string-plus-int > >> -Wno-unused-const-variable -Wno-error=3Dunused-but-set-parameter > >> -Wno-error=3Dcast-function-type-mismatch -Wno-tautological-compare > >> -Wno-unused-value > >> -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion > >> -Wno-unused-local-typedef > >> -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum > >> -Wno-knr-promoted-parameter > >> -Wno-parentheses -Oz -Qunused-arguments -c > >> /usr/src/lib/libsecureboot/efi/efi_variables.c > >> -o efi_variables.o In file included from > >> /usr/src/lib/libsecureboot/efi/efi_variables.c:31: > >> /usr/src/stand/efi/include/efi.h:47:10: fatal error: 'Uefi.h' file not > >> found 47 | #include > >> > >> [...] =20 > > > > > > I've done 20 buildworlds today. And on what architecture? What do you h= ave > > in your src.conf since I'm not seeing this and I didn't think we built > > libsecureboot by default. I certainly didn't fix it and didn't expect i= t to > > include efi.h from stand. I'm skeptical about why since that file is > > tailored to the boot loader only. > > > > Warner > > =20 >=20 > Oh, I see. WITH_BEARSSL and WITH_LOADER_EFI_SECUREBOOT must have been > selected. I just fixed this with 3c5ca68b9b7c. Unless it's something else, > in which case I'll need more details. >=20 > Warner A standard UEFI loader (/boot/loader.efi) built with the recent sources and= installed properly in /EFI/BOOT/ results in a locked up box (black screen, touch on/off switch= acts immediately, no usual latency when box is up and has no screen).=20 I only have WITH_BEARSSL defined in /etc/src.conf, not WITH_LOADER_EFI_SECU= REBOOT as it is set implicitely as mentioned in the manpage of src.conf. Also set, just for the record: WITHOUT_LOADER_PXEBOOT=3D YES LOADERSIZE?=3D 525000 probably not important. --=20 A FreeBSD user --Sig_/TlOH9YXa5uMGJ4f6CzYkjgH Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRQheDybVktG5eW/1Kxzvs8OqokrwUCaRtUxQAKCRCxzvs8Oqok r17yAQD9QnQB//z1CLQT5XlTFdExWi9fMfhDD6FBI18LTaLHHgEA069K658d2eAt tgb92enOTVPfTvFkBA3lRb2H7WH04Qw= =PU+Q -----END PGP SIGNATURE----- --Sig_/TlOH9YXa5uMGJ4f6CzYkjgH--