From owner-freebsd-ports@FreeBSD.ORG  Tue Jan 17 10:39:28 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@FreeBSD.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AD36416A422;
	Tue, 17 Jan 2006 10:39:28 +0000 (GMT)
	(envelope-from boris@brooknet.com.au)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4990543D5E;
	Tue, 17 Jan 2006 10:39:22 +0000 (GMT)
	(envelope-from boris@brooknet.com.au)
Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au
	[61.8.0.86])
	by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id
	k0HAdB1c028229; Tue, 17 Jan 2006 21:39:11 +1100
Received: from [61.8.44.149] (ppp2C95.dyn.pacific.net.au [61.8.44.149])
	by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id
	k0HAd9Op023009; Tue, 17 Jan 2006 21:39:10 +1100
In-Reply-To: <43CC3140.9040604@FreeBSD.org>
References: <200601150911.k0F9B6eG062331@repoman.freebsd.org>
	<43CC3140.9040604@FreeBSD.org>
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <8F69821A-31A2-4E2D-A9E9-5CE1BEB2EE1F@brooknet.com.au>
Content-Transfer-Encoding: 7bit
From: Sam Lawrance <boris@brooknet.com.au>
Date: Tue, 17 Jan 2006 21:39:07 +1100
To: Doug Barton <dougb@FreeBSD.org>
X-Mailer: Apple Mail (2.746.2)
Cc: ports@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>
Subject: Re: cvs commit: ports/mail/dk-milter Makefile pkg-plist
	ports/mail/dk-milter/files milter-dk.sh.in
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2006 10:39:29 -0000

Over to ports@ ...

On 17/01/2006, at 10:50 AM, Doug Barton wrote:

> Pav Lucistnik wrote:
>> pav         2006-01-15 09:11:04 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>>     mail/dk-milter       Makefile pkg-plist
>>     mail/dk-milter/files milter-dk.sh.in
>>   Log:
>>   - Convert RC script to rc_subr
>>
>>   PR:             ports/91595  http://www.FreeBSD.org/cgi/query- 
>> pr.cgi?pr=91595
>>   Submitted by:   Hirohisa Yamaguchi <umq@ueo.co.jp>
>>
>>   Revision  Changes    Path
>>   1.6       +3 -2      ports/mail/dk-milter/Makefile
>>   1.2       +43 -48    ports/mail/dk-milter/files/milter-dk.sh.in
>>   1.2       +0 -1      ports/mail/dk-milter/pkg-plist
>>
>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/ 
>> Makefile.diff?&r1=1.5&r2=1.6&f=h
>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/files/ 
>> milter-dk.sh.in.diff?&r1=1.1&r2=1.2&f=h
>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/pkg- 
>> plist.diff?&r1=1.1&r2=1.2&f=h
>
> It's not a big enough issue to warrant a change for this port, but in
> general it's a good idea if the name of the rc.d file is the same  
> as what
> the script PROVIDE's. This removes one potential source of  
> confusion for users.

Is it worth a patch to portlint?  There are probably a stack of other  
rc-related things that could be checked for, too.  For example, if an  
rc script is in the packing list, warn to use USE_RC_SUBR.  Others?