From owner-freebsd-current Wed Dec 19 11:13:15 2001 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 6352A37B417; Wed, 19 Dec 2001 11:13:12 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id fBJJDBu90110; Wed, 19 Dec 2001 11:13:11 -0800 (PST) (envelope-from dillon) Date: Wed, 19 Dec 2001 11:13:11 -0800 (PST) From: Matthew Dillon Message-Id: <200112191913.fBJJDBu90110@apollo.backplane.com> To: John Baldwin Cc: freebsd-current@FreeBSD.org, Josef Karthauser Subject: Re: cvs commit: src/sys/kern vfs_subr.c vfs_vnops.c src/sys/sys References: Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :> The structure is being bzero()'d before its dynamic flag gets checked. :> I've included a patch below. Josef, I would appreciate it if you would :> apply the patch and try your system with the various procfs devices :> mounted again. It's an obvious bug so I'm comitting it to -current now, :> the question is: Is it the *only* bug? :> :> -Matt : :Hmm, why bzero at all if you are just going to free it? Why not move the bzero :to an else after the ISDYNSTRUCT check? (Not that this is really all that :important, but... :) : :-- : :John Baldwin <>< http://www.FreeBSD.org/~jhb/ He is invalidating the structure to catch references to deleted sbufs. (see assert_sbuf_integrity() calls). Josef, I take back my last request... I think there's another bug. Your vmstat -m output showed that both the sbuf pool and the VFS cache pool were blown up. The fix I just made will probably only solve the sbuf pool issue. If you still want to test it, observe both pools in the vmstat -m output carefully! -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message