From owner-svn-src-all@freebsd.org Fri Jul 15 06:53:51 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B32AB99D14; Fri, 15 Jul 2016 06:53:51 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id AC8BF1382; Fri, 15 Jul 2016 06:53:50 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r302324 - head/lib/libc/locale To: koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201607031500.u63F0Cr8099783@repo.freebsd.org> <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> <677f087c-1270-8435-83c7-a240ed2599b2@FreeBSD.org> Cc: Baptiste Daroussin From: Jung-uk Kim Message-ID: <75d6cece-4b8a-8b47-5993-577b955a03ba@FreeBSD.org> Date: Fri, 15 Jul 2016 02:53:42 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <677f087c-1270-8435-83c7-a240ed2599b2@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4Tpdaki2hhPMwQ8cGPkdj8fEvCNvLeRbi" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 06:53:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4Tpdaki2hhPMwQ8cGPkdj8fEvCNvLeRbi Content-Type: multipart/mixed; boundary="3GoadeKG0dIdHqH1ELkKcDS2xq7FHugab" From: Jung-uk Kim To: koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: Baptiste Daroussin Message-ID: <75d6cece-4b8a-8b47-5993-577b955a03ba@FreeBSD.org> Subject: Re: svn commit: r302324 - head/lib/libc/locale References: <201607031500.u63F0Cr8099783@repo.freebsd.org> <3a667ad2-f7d1-7720-3929-99c12245733e@FreeBSD.org> <677f087c-1270-8435-83c7-a240ed2599b2@FreeBSD.org> In-Reply-To: <677f087c-1270-8435-83c7-a240ed2599b2@FreeBSD.org> --3GoadeKG0dIdHqH1ELkKcDS2xq7FHugab Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/15/16 02:22 AM, Kubilay Kocak wrote: > On 15/07/2016 4:19 PM, Jung-uk Kim wrote: >> On 07/03/16 11:00 AM, Baptiste Daroussin wrote: >>> Author: bapt >>> Date: Sun Jul 3 15:00:12 2016 >>> New Revision: 302324 >>> URL: https://svnweb.freebsd.org/changeset/base/302324 >>> >>> Log: >>> Fix a bad test resulting in a segfault with ISO-8859-5 locales >>> =20 >>> Reported by: Lauri Tirkkonen from Illumos >>> Approved by: re@ (gjb) >>> >>> Modified: >>> head/lib/libc/locale/collate.c >>> >>> Modified: head/lib/libc/locale/collate.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/lib/libc/locale/collate.c Sun Jul 3 11:45:54 2016 (r302323)= >>> +++ head/lib/libc/locale/collate.c Sun Jul 3 15:00:12 2016 (r302324)= >>> @@ -310,7 +310,7 @@ _collate_lookup(struct xlocale_collate * >>> if ((sptr =3D *state) !=3D NULL) { >>> *pri =3D *sptr; >>> sptr++; >>> - if ((sptr =3D=3D *state) || (sptr =3D=3D NULL)) >>> + if ((sptr =3D=3D *state) || (*sptr =3D=3D 0)) >>> *state =3D NULL; >>> else >>> *state =3D sptr; >> >> I had a serious regression with ko_KR.UTF-8 locale after this commit. >> MATE is unusable because mate-panel is busy looping and eating 100% CP= U. >> GNOME 3 does not start at all, i.e., nothing but mouse cursor on blac= k >> screen. After reverting this commit, everything is back to normal. >> Please investigate. IMHO, this must be fixed before 11.0-BETA2 build.= >> >> Thanks, >> >> Jung-uk Kim >> >=20 > Please report a bug so it can be tracked and not forgotten: >=20 > Add re@ and original committer to cc > Set mfc-stable11 to ? > Add keyword: regression Done: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211135 Jung-uk Kim --3GoadeKG0dIdHqH1ELkKcDS2xq7FHugab-- --4Tpdaki2hhPMwQ8cGPkdj8fEvCNvLeRbi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXiIh+AAoJEHyflib82/FG/4QH/0Xrz61VfNVMtEIxpL/eoIT+ KI7vs61izqIp6RKUctf37wrErI9x0sdy3LCFAU1hIvBksrIJ1be1GtfRLr1drVv/ 8RLv29Rom9zgtipr2pbf8th3n9sQbwRfPjf6ljTwO4HTwwtmvrGM6F8j7RHS1VIP tWU12tbSJ8x6IC3Fqnn/o5NAAaagWbzaKqXw0MNdegBOwLoYV6mmFzqGjuwmKpoS mNBoS+5oxXUMpQ5gJoXQ6mV8+NvyTyb0SS+rdB+OTjtlC2JIB0LZFm2wJstfb5Yf LW3Ax+CoeWW5gFeD0cZTW10pVPelKs8P072UZ5/aUx7JBC85mUdjjFi/37i8Deg= =T/yS -----END PGP SIGNATURE----- --4Tpdaki2hhPMwQ8cGPkdj8fEvCNvLeRbi--