From owner-svn-src-all@FreeBSD.ORG Mon May 4 04:52:15 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 19E6BC34; Mon, 4 May 2015 04:52:15 +0000 (UTC) Received: from smtp2.wemm.org (smtp2.wemm.org [IPv6:2001:470:67:39d::78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp2.wemm.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0080A187E; Mon, 4 May 2015 04:52:15 +0000 (UTC) Received: from overcee.wemm.org (canning.wemm.org [192.203.228.65]) by smtp2.wemm.org (Postfix) with ESMTP id CED87763; Sun, 3 May 2015 21:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=m20140428; t=1430715133; bh=TBlsR4SLdyi9A8VYs2CqbLTPVvS2kgeOUt08dFIRPE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kbGqRGmIemn+2TDaKF1+NM70VRh2J0d6oWLgZct5X1gJnk0aY+iIaXMEA+dyjEUVY GNFI5F+oqXISZyp4oO/h3S/otJGMG2bLj2XRW+/S5kH7Zi1jtEkchrBnQ2i0kGhUQh bZ2r7gw7S+wraS9ANDBt/tf32KRt5C5b8a/ZJUv8= From: Peter Wemm To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281643 - head/sys/net Date: Sun, 03 May 2015 21:52:08 -0700 Message-ID: <1771261.fW4ZlvR2Pp@overcee.wemm.org> User-Agent: KMail/4.14.3 (FreeBSD/11.0-CURRENT; KDE/4.14.3; amd64; ; ) In-Reply-To: <1897115.Jgl4mMPfrQ@overcee.wemm.org> References: <201504170639.t3H6dGd7075429@svn.freebsd.org> <1897115.Jgl4mMPfrQ@overcee.wemm.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart238538607.hU2ZEmULYq"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 04:52:15 -0000 --nextPart238538607.hU2ZEmULYq Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Sunday, May 03, 2015 09:31:01 PM Peter Wemm wrote: > On Friday, April 17, 2015 06:39:16 AM Gleb Smirnoff wrote: > > Author: glebius > > Date: Fri Apr 17 06:39:15 2015 > > New Revision: 281643 > > URL: https://svnweb.freebsd.org/changeset/base/281643 > >=20 > > Log: > > Bring in if_types.h from projects/ifnet, where types are > > defined in enum. > >=20 > > Modified: > > head/sys/net/if_types.h >=20 > I'm sorry, but this breaks the freebsd.org cluster. >=20 > 281642 works > 281643 fails > head with 281643 reverted works >=20 > IPv6 doesn't work on systems with pf, carp and multiple interfaces. = I have > nothing more specific than that. The kernel is smaller with the enums: text data bss dec hex =20 11438123 730686 2998048 15166857 0xe76d89 =20 11437787 730686 2998048 15166521 0xe76c39 The first is with the #defines, the second is enums. The enums caused = 336 bytes=20 less code to be generated, so presumably the enums enabled some "optimi= zation"=20 that wasn't expected. =2D-=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI= 6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 --nextPart238538607.hU2ZEmULYq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJVRvr4AAoJEDXWlwnsgJ4E7/kIALIQZG7zBSG4yRgZffm1QeI3 ElTzB7NbbKXscaSLOjLGL9vOC0oZuMXV3YT8Ub3q5ZlH1l9Ds2XtWtCO6o/AZZRy NdxTghzGcgDHV/oPzOdgAT1FgOjBXfECbO+Us72mujijEg0fGyq20dleVauZqs/r AOZIPLlF9So9TQHm9W2Ja1JlRwO+RNTcG4lat20LRSRVuI/i1Z1XzSeGf2JR1qnA 7hmfq+l5X9j71yP8JYgZAKux1bkRg/g8ugRNejxV6wd5sVhrIqUVLNK/hlJQOjVc bofkwNzE5pNc0nRrnO3tAgtjdOvmE4CAQgfsxxvptm2eL1pQWII3JBFkOfB/G7k= =0Fck -----END PGP SIGNATURE----- --nextPart238538607.hU2ZEmULYq--