From owner-svn-src-all@freebsd.org Sat Nov 18 20:55:39 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AAA3DDC1E5; Sat, 18 Nov 2017 20:55:39 +0000 (UTC) (envelope-from manu@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C0BF17D02B; Sat, 18 Nov 2017 20:55:38 +0000 (UTC) (envelope-from manu@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vAIKtbHN026263; Sat, 18 Nov 2017 20:55:37 GMT (envelope-from manu@FreeBSD.org) Received: (from manu@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vAIKtb8i026262; Sat, 18 Nov 2017 20:55:37 GMT (envelope-from manu@FreeBSD.org) Message-Id: <201711182055.vAIKtb8i026262@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: manu set sender to manu@FreeBSD.org using -f From: Emmanuel Vadot Date: Sat, 18 Nov 2017 20:55:37 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r325981 - head/sys/arm/allwinner X-SVN-Group: head X-SVN-Commit-Author: manu X-SVN-Commit-Paths: head/sys/arm/allwinner X-SVN-Commit-Revision: 325981 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2017 20:55:39 -0000 Author: manu Date: Sat Nov 18 20:55:37 2017 New Revision: 325981 URL: https://svnweb.freebsd.org/changeset/base/325981 Log: if_awg: replace multiple calls to if_setdrvflagbits with one call in awg_txintr Small optimization Submitted by: Guy Yur Differential Revision: https://reviews.freebsd.org/D13033 Modified: head/sys/arm/allwinner/if_awg.c Modified: head/sys/arm/allwinner/if_awg.c ============================================================================== --- head/sys/arm/allwinner/if_awg.c Sat Nov 18 20:50:31 2017 (r325980) +++ head/sys/arm/allwinner/if_awg.c Sat Nov 18 20:55:37 2017 (r325981) @@ -916,7 +916,7 @@ awg_txintr(struct awg_softc *sc) struct emac_desc *desc; uint32_t status, size; if_t ifp; - int i; + int i, prog; AWG_ASSERT_LOCKED(sc); @@ -924,6 +924,8 @@ awg_txintr(struct awg_softc *sc) BUS_DMASYNC_POSTREAD | BUS_DMASYNC_POSTWRITE); ifp = sc->ifp; + + prog = 0; for (i = sc->tx.next; sc->tx.queued > 0; i = TX_NEXT(i)) { desc = &sc->tx.desc_ring[i]; status = le32toh(desc->status); @@ -936,11 +938,14 @@ awg_txintr(struct awg_softc *sc) else if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1); } + prog++; awg_clean_txbuf(sc, i); - if_setdrvflagbits(ifp, 0, IFF_DRV_OACTIVE); } - sc->tx.next = i; + if (prog > 0) { + sc->tx.next = i; + if_setdrvflagbits(ifp, 0, IFF_DRV_OACTIVE); + } } static void