Date: Mon, 07 Aug 2006 23:20:55 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: Boris Samorodov <bsam@ipt.ru>, freebsd-ports@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: extract both bz2 and gz files from distfiles Message-ID: <1154985655.95608.8.camel@ikaros.oook.cz> In-Reply-To: <20060807210603.GA85637@lor.one-eyed-alien.net> References: <14817321@bsam.ru> <20060807183724.GA47899@xor.obsecurity.org> <16560673@bsam.ru> <20060807201203.GA84762@lor.one-eyed-alien.net> <50488990@bsam.ru> <1154984178.95608.6.camel@ikaros.oook.cz> <20060807210603.GA85637@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-o797vMgGhm3Qilitw/pn
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Brooks Davis p=ED=B9e v po 07. 08. 2006 v 16:06 -0500:
> On Mon, Aug 07, 2006 at 10:56:18PM +0200, Pav Lucistnik wrote:
> > Boris Samorodov p??e v ?t 08. 08. 2006 v 00:24 +0400:
> > > On Mon, 7 Aug 2006 15:12:03 -0500 Brooks Davis wrote:
> > > > On Mon, Aug 07, 2006 at 11:56:46PM +0400, Boris Samorodov wrote:
> > > > > On Mon, 7 Aug 2006 14:37:25 -0400 Kris Kennaway wrote:
> > > > > > On Mon, Aug 07, 2006 at 03:12:06AM +0400, Boris Samorodov wrote=
:
> > > > >=20
> > > > > > > We have got a port (lang/gnat-gcc34) which has both bz2 and g=
z
> > > > > > > distfiles. As for 5.x+ extracting is gone automagically. But =
not at
> > > > > > > 4.x. Well, at 4.x extracting may be done for example, by usin=
g
> > > > > > > USE_BZIP2 knob and doing gunzipping at after-extract:.
> > > > > > >=20
> > > > > > > Does someone know a better solution?
> > > > > > > Does we have examples at our ports?
> > > > >=20
> > > > > > Use a do-extract that extracts all distfiles or EXTRACT_ONLY wi=
th
> > > > > > post-extract that extracts the other ones.
> > > > >=20
> > > > > Thanks, Kris. I'm trying to test (actually, to find an 4.x system=
)
> > > > > some broken ports with a patch(es) which includes (thanks Brooks)=
:
> > > > > -----
> > > > > .if ${OSVERSION} < 500000
> > > > > EXTRACT_DEPENDS+=3D bsdtar:${PORTSDIR}/archivers/libarchive
> > > > > TAR=3D /usr/local/bin/bsdtar
> > > > > .endif
> > > > > -----
> > > > >=20
> > > > > To me that seems a good solution.
> > >=20
> > > > I'd suggest using not using an absolute path in the TAR definition
> > > > since the dependency check doesn't and using 502111 as the version =
since
> > > > that's the first version bump after the initial bsdtar import. Not=
that
> > > > we really need to worry about such early 5.x release, but it's more
> > > > correct.
> > >=20
> > > Thanks again, Brooks. The patch will include (if Kris won't complain)=
:
> > > -----
> > > .if ${OSVERSION} < 502111
> > > EXTRACT_DEPENDS+=3D bsdtar:${PORTSDIR}/archivers/libarchive
> > > TAR=3D bsdtar
> > > .endif
> > > -----
> >=20
> > Would writing own do-extract: target be better alternative?
>=20
> It seems list unnecessicary work to me. The nice thing about setting to
> TAR bsdtar is that you get the same behavior on all releases. Obviously
> a do-extract target would work, but this way we can get rid of the
> compatability code at some point in the future. In some ways I think
> we should consider alwasy depending on bsdtar in older versions just to
> eliminate the differences and to reduce cross branch compatability
> issues now that less and less people can test on 4.x systems.
So you prefer imposing yet another dependency on the user is less evil
than adding few lines of extra code in port Makefile?
Interesting PoV.
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
Alignment: Neutral Greedy
--=-o797vMgGhm3Qilitw/pn
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQBE1663ntdYP8FOsoIRAtxvAJ4lMd14XmrJnmY7PaWhU6S0cG1q4gCdEN4X
ivH5ZR3ek3S2i7RkD6YdeDY=
=72iX
-----END PGP SIGNATURE-----
--=-o797vMgGhm3Qilitw/pn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1154985655.95608.8.camel>