From owner-svn-ports-all@freebsd.org Wed Feb 3 09:05:29 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3BD2B53079C; Wed, 3 Feb 2021 09:05:29 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DVwkc4BXMz3ppx; Wed, 3 Feb 2021 09:05:28 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id D811F33E53; Wed, 3 Feb 2021 04:05:27 -0500 (EST) Received: from [192.168.1.5] (77.118.111.172.wireless.dyn.drei.com [77.118.111.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id D88FD33E4C; Wed, 3 Feb 2021 04:05:26 -0500 (EST) Date: Wed, 3 Feb 2021 10:05:19 +0100 (CET) From: Gerald Pfeifer To: Li-Wen Hsu , thomas@bsdunix.ch, michael@fuckner.net cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540710 - head/sysutils/arcconf In-Reply-To: <202006281346.05SDkfaS050010@repo.freebsd.org> Message-ID: <3c213f5-9fb6-c09c-e436-7d4d95619d46@pfeifer.com> References: <202006281346.05SDkfaS050010@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DVwkc4BXMz3ppx X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-3.30 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[gerald]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.68.5.143:from]; RCPT_COUNT_FIVE(0.00)[6]; SPAMHAUS_ZRD(0.00)[209.68.5.143:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[svn-ports-all,svn-ports-head] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2021 09:05:29 -0000 On Sun, 28 Jun 2020, Li-Wen Hsu wrote: > Log: > Robustness fix and license updates > > - Update Makefile to use current version of GCC as defined in > bsd.default-versions.mk. (USE_GCC=yes) > - Update Makefile with LICENSE and LICENSE_PERMS information and remove > RESTRICTED and NO_CDROM (redundant) > - Update Makefile PORTREVISION > > While here, pet portlint > > PR: 243142 > Submitted by: thomas@bsdunix.ch > Approved by: michael@fuckner.net (maintainer) > LIB_DEPENDS= libstdc++.so.6:lang/gcc${GCC_DEFAULT} > +USE_GCC= yes This looks very (very) odd. USE_GCC already implies a run-time dependency on lang/gcc${GCC_DEFAULT} and I do not recall seeing such a LIB_DEPENDS before. Are you sure this is really, really needed with USE_GCC=yes? (It would be nicer not to depend on GCC to begin with; this double dependency doesn't look right and the LIB_DEPENDS probably should be removed.) Gerald