Date: Wed, 3 Feb 2021 10:05:19 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Li-Wen Hsu <lwhsu@FreeBSD.org>, thomas@bsdunix.ch, michael@fuckner.net Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540710 - head/sysutils/arcconf Message-ID: <3c213f5-9fb6-c09c-e436-7d4d95619d46@pfeifer.com> In-Reply-To: <202006281346.05SDkfaS050010@repo.freebsd.org> References: <202006281346.05SDkfaS050010@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 28 Jun 2020, Li-Wen Hsu wrote:
> Log:
> Robustness fix and license updates
>
> - Update Makefile to use current version of GCC as defined in
> bsd.default-versions.mk. (USE_GCC=yes)
> - Update Makefile with LICENSE and LICENSE_PERMS information and remove
> RESTRICTED and NO_CDROM (redundant)
> - Update Makefile PORTREVISION
>
> While here, pet portlint
>
> PR: 243142
> Submitted by: thomas@bsdunix.ch
> Approved by: michael@fuckner.net (maintainer)
> LIB_DEPENDS= libstdc++.so.6:lang/gcc${GCC_DEFAULT}
> +USE_GCC= yes
This looks very (very) odd.
USE_GCC already implies a run-time dependency on lang/gcc${GCC_DEFAULT}
and I do not recall seeing such a LIB_DEPENDS before.
Are you sure this is really, really needed with USE_GCC=yes?
(It would be nicer not to depend on GCC to begin with; this double
dependency doesn't look right and the LIB_DEPENDS probably should be
removed.)
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c213f5-9fb6-c09c-e436-7d4d95619d46>