From owner-freebsd-fs@FreeBSD.ORG Sat Jul 14 21:04:34 2007 Return-Path: X-Original-To: freebsd-fs@freebsd.org Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A430D16A407 for ; Sat, 14 Jul 2007 21:04:34 +0000 (UTC) (envelope-from soc@hbar.us) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 4277E13C4BA for ; Sat, 14 Jul 2007 21:04:34 +0000 (UTC) (envelope-from soc@hbar.us) Received: by ug-out-1314.google.com with SMTP id o4so860124uge for ; Sat, 14 Jul 2007 14:04:33 -0700 (PDT) Received: by 10.78.195.9 with SMTP id s9mr794365huf.1184447072641; Sat, 14 Jul 2007 14:04:32 -0700 (PDT) Received: by 10.78.138.5 with HTTP; Sat, 14 Jul 2007 14:04:32 -0700 (PDT) Message-ID: <47a4f3080707141404w694570e5x9620e344f111e3bb@mail.gmail.com> Date: Sat, 14 Jul 2007 17:04:32 -0400 From: "Brian Chu" To: "Poul-Henning Kamp" In-Reply-To: <80555.1184332747@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <47a4f3080707130119xbee4477y3e96d27763f793aa@mail.gmail.com> <80555.1184332747@critter.freebsd.dk> Cc: freebsd-fs@freebsd.org Subject: Re: msdosfs header unification patch X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2007 21:04:34 -0000 Hi Poul-Henning, Wow, there IS a fourth copy! Getting on it. Brian On 7/13/07, Poul-Henning Kamp wrote: > In message <47a4f3080707130119xbee4477y3e96d27763f793aa@mail.gmail.com>, "Brian > Chu" writes: > > >The included diff is the work I've done on header consolidation in > >msdosfs. The three areas I concentrated on where: > > > >- sys/fs/msdosfs/ > >- sys/geom/label/g_label_msdosfs.* > >- sbin/fsck_msdosfs/ > > This is *SO* great that I hate to point out that you missed > one set of copies: src/sbin/newfs_msdos/newfs_msdos.c > > But THANK YOU! > > I have hated these multiple incompatible copies for sooo many years... > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. >