From owner-freebsd-current@FreeBSD.ORG  Mon Aug 25 01:20:15 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9EF1B16A4BF
	for <freebsd-current@freebsd.org>;
	Mon, 25 Aug 2003 01:20:15 -0700 (PDT)
Received: from mercury.infolab.ne.jp (ns1.infolab.ne.jp [210.166.231.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 54F6543FE1
	for <freebsd-current@freebsd.org>;
	Mon, 25 Aug 2003 01:20:14 -0700 (PDT)
	(envelope-from hatanou@infolab.ne.jp)
Received: from mercury.infolab.ne.jp (localhost [127.0.0.1])
	by mercury.infolab.ne.jp (8.12.9/8.12.9) with ESMTP id h7P8KDp2063902
	for <freebsd-current@freebsd.org>;
	Mon, 25 Aug 2003 17:20:13 +0900 (JST)
	(envelope-from hatanou@ns1.infolab.ne.jp)
Message-Id: <200308250820.h7P8KDp2063902@mercury.infolab.ne.jp>
To: freebsd-current@freebsd.org
In-reply-to: S,Axren Schmidt's message of "Sun, 24 Aug 2003 15:28:45 +0200."
             <200308241328.h7ODSjwC067165@spider.deepcore.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Date: Mon, 25 Aug 2003 17:20:13 +0900
From: HATANOU Tomomi <hatanou@infolab.ne.jp>
Subject: Re: HEADS UP! ATAng committed
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2003 08:20:15 -0000

>> Coolness. Judging from the CVS log, it also gets ATA out under Giant? 
>
>Yes it does.

I've noticed that, in ata-raid.c:ar_rebuid(), Giant is
locked and never unlocked.  Is it ok?

% ident ata-raid.c
ata-raid.c:
     $FreeBSD: src/sys/dev/ata/ata-raid.c,v 1.67 2003/08/24 17:48:05 obrien Exp $
% grep Giant ata-raid.c
    mtx_lock(&Giant);
%

HATANOU Tomomi
infolab.