From owner-svn-ports-all@freebsd.org  Fri Sep 15 10:33:38 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FF12E0CD30;
 Fri, 15 Sep 2017 10:33:38 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 499D724C3;
 Fri, 15 Sep 2017 10:33:37 +0000 (UTC) (envelope-from des@des.no)
Received: from desk.des.no (smtp.des.no [194.63.250.102])
 by smtp.des.no (Postfix) with ESMTP id 057EB10737;
 Fri, 15 Sep 2017 10:33:37 +0000 (UTC)
Received: by desk.des.no (Postfix, from userid 1001)
 id 4030821CF; Fri, 15 Sep 2017 10:33:39 +0000 (UTC)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Steve Wills <swills@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r449798 - head/net-mgmt/collectd5
References: <201709131455.v8DEtjVq069144@repo.freebsd.org>
 <305b87d4-297e-e569-7011-9c322984206d@FreeBSD.org>
Date: Fri, 15 Sep 2017 12:33:39 +0200
In-Reply-To: <305b87d4-297e-e569-7011-9c322984206d@FreeBSD.org> (Steve Wills's
 message of "Thu, 14 Sep 2017 18:12:15 -0400")
Message-ID: <8660cki73w.fsf@desk.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Sep 2017 10:33:38 -0000

Steve Wills <swills@FreeBSD.org> writes:
> I'm happy to see more options enabled by default in this port, thanks
> for that. We do have a policy that packaged binaries should be
> stripped. Enabling the DEBUG option by default would seem to be at
> odds with that policy to me. Could you please turn that one off by
> default?

# file /usr/local/sbin/collectd
/usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (Fre=
eBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 11=
.0 (1100122), FreeBSD-style, stripped

The DEBUG option enables log messages which are indispensable when
troubleshooting a collectd installation (or rather, makes an additional
log level available).  I didn't realize that it also disables stripping.
If that is the case, it needs to be split in two, or maybe the relevant
configure argument should simply be hardcoded.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no