From owner-freebsd-ports Fri Apr 4 04:30:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA05440 for ports-outgoing; Fri, 4 Apr 1997 04:30:04 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id EAA05434; Fri, 4 Apr 1997 04:30:03 -0800 (PST) Resent-Date: Fri, 4 Apr 1997 04:30:03 -0800 (PST) Resent-Message-Id: <199704041230.EAA05434@freefall.freebsd.org> Resent-From: gnats (GNATS Management) Resent-To: freebsd-ports Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, sanpei@yy.cs.keio.ac.jp Received: from titanium.yy.cs.keio.ac.jp (titanium.yy.cs.keio.ac.jp [131.113.47.73]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id EAA05083 for ; Fri, 4 Apr 1997 04:21:13 -0800 (PST) Received: from lavender.sanpei.org ([203.140.35.7]) by titanium.yy.cs.keio.ac.jp (8.8.4+2.7Wbeta4/3.5Wpl3) with ESMTP id VAA27718 for ; Fri, 4 Apr 1997 21:21:03 +0900 (JST) Received: (from sanpei@localhost) by lavender.sanpei.org (8.7.6/3.5Wpl3) id VAA00839; Fri, 4 Apr 1997 21:20:59 +0900 (JST) Message-Id: <199704041220.VAA00839@lavender.sanpei.org> Date: Fri, 4 Apr 1997 21:20:59 +0900 (JST) From: sanpei@yy.cs.keio.ac.jp Reply-To: sanpei@yy.cs.keio.ac.jp To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.2 Subject: ports/3192: sysinstall does not read RUN_DEPEND in package install phase Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk >Number: 3192 >Category: ports >Synopsis: sysinstall does not read RUN_DEPEND in package install phase >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-ports >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 4 04:30:01 PST 1997 >Last-Modified: >Originator: MIHIRA Yoshiro >Organization: Keio Univ. Japan >Release: FreeBSD 2.2.1-RELEASE >Environment: 2.2.1-RELEASE >Description: /stand/sysinstall is not install RUN_DEPEND packages at package install phase. I think: (1) sysintall read INDEX file via sysinstall/index.c index_parse function (2) index_parse function uses copy_to_sep function as: > (void)copy_to_sep(rdeps, cp, '|'); Ļģ) information of RUN_DEPEND is listed at end of field, more over that field is not ended with `|'. (4) copy_to_sep is as below: 1> copy_to_sep(char *to, char *from, int sep) 2> { 3> char *tok; 4> 5> tok = strchr(from, sep); 6> if (!tok) { 7> *to = '\0'; 8> return 0; 9> } (5) In copy_to_sep(rdeps, cp, '|'), *strchr* in line 5 returns 0 and return via line 8 to index_parse function, because there is no `|' string after RUN_DEPEND field. (6) copy_to_sep copy any strings from INDEX file. (7) RUN_DEPEND infomation is not reflected. I hope to fix this. Thank you. >How-To-Repeat: >Fix: >Audit-Trail: >Unformatted: