From owner-freebsd-net@FreeBSD.ORG  Sat May 30 02:20:04 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF2191065673
	for <freebsd-net@hub.freebsd.org>; Sat, 30 May 2009 02:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A4A8F8FC19
	for <freebsd-net@hub.freebsd.org>; Sat, 30 May 2009 02:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4U2K4w6092971
	for <freebsd-net@freefall.freebsd.org>; Sat, 30 May 2009 02:20:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4U2K4Nn092970;
	Sat, 30 May 2009 02:20:04 GMT (envelope-from gnats)
Date: Sat, 30 May 2009 02:20:04 GMT
Message-Id: <200905300220.n4U2K4Nn092970@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Julian Elischer <julian@elischer.org>
Cc: 
Subject: Re: kern/135067: [patch] [fib] Incorrect KASSERTs in sys/net/route.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Julian Elischer <julian@elischer.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 May 2009 02:20:05 -0000

The following reply was made to PR kern/135067; it has been noted by GNATS.

From: Julian Elischer <julian@elischer.org>
To: bug-followup@FreeBSD.org, mjguzik@gmail.com
Cc:  
Subject: Re: kern/135067: [patch] [fib] Incorrect KASSERTs in sys/net/route.c
Date: Fri, 29 May 2009 18:58:48 -0700

 if you have 16 fibs then valid values are 0,1,2,.....14,15
 
 if fibnum == rt_numfibs then that is an error.
 
 thus in setfib... if uap->numfbs is 16 OR GREATER  it is and EINVAL
 
 and the kasserts in route.c need to check that fibnum is  LESS THAN
 rt_numfibs.
 
 so this looks correct to me..
 
 what makes you think there is an error?