From owner-svn-src-all@freebsd.org Fri Nov 13 20:39:47 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49A8BA2E587; Fri, 13 Nov 2015 20:39:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2ED6119A3; Fri, 13 Nov 2015 20:39:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 26B9711E7; Fri, 13 Nov 2015 20:39:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id CD52716B5A; Fri, 13 Nov 2015 20:39:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id LtaxggaXJOqR; Fri, 13 Nov 2015 20:39:44 +0000 (UTC) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com CEA4B16B55 To: "Alexander V. Chernikov" , Randall Stewart , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56464A90.2040405@FreeBSD.org> Date: Fri, 13 Nov 2015 12:39:44 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1660421447413365@web19h.yandex.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CW9sTjHg6mdRojhStSbqKAP5Ogfq95RTg" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 20:39:47 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CW9sTjHg6mdRojhStSbqKAP5Ogfq95RTg Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 11/13/2015 3:16 AM, Alexander V. Chernikov wrote: > 10.11.2015, 17:49, "Randall Stewart" : >> Author: rrs >> Date: Tue Nov 10 14:49:32 2015 >> New Revision: 290664 >> URL: https://svnweb.freebsd.org/changeset/base/290664 >> >> Log: >> Add new async_drain to the callout system. This is so-far not used b= ut >> should be used by TCP for sure in its cleanup of the IN-PCB (will be= coming shortly). >=20 > Randall, this commit introduced change in callout_stop() which was not = mentioned in commit message. > This change has broken lltable arp/nd handling: deleting interface addr= ess causes immediate panic. > I also see other other code/subsystems relying on callout_stop() return= value (netgraph, pfsync, iscsi). > I was not able to find any discussion/analysis/testing for these in D40= 76 so this change does not look like being properly tested prior commitin= g.. >=20 >=20 Fixing this is pretty easy. Keeping _callout_stop_safe() as a function wrapper around a new _callstop_stop_safe_drain() that takes the new argument. Then change callout_stop define to use _callstop_stop_safe_drain(). New code will avoid the wrapper function as it is recompiled. --=20 Regards, Bryan Drewery --CW9sTjHg6mdRojhStSbqKAP5Ogfq95RTg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRkqQAAoJEDXXcbtuRpfP2MgH/Rsb4k6DoC+2RpUWM18GiuB5 YXoWqzhOguIJ3pYfujBT1rddw2s7J31ZB+Q3RhMJUoBadqEilFUGK1Pr73U3TZeP nmXLwi+X3ETal25nb0MmPVlm2NLuW1NdBNxrmxb5dJxIdUEeEWTLApV+yjE1NdaX i9BQEnYGbxk6yzVxHeRj79fNchTkpBX1woHlI4yXTRLn9OOrvIAh8No5OlDK1mCp oGGn3cAbTZjhr+RFUPTas4swfEh4I33HCOvQMbmdJixvHC1l3E1pQWMxFYN0fWdr KhuBfomzcF2mP3lRNEweE47tg6+iIGUKwgeGhYiJf7arImA5tT9BC8sbgzj4gHE= =0Pmp -----END PGP SIGNATURE----- --CW9sTjHg6mdRojhStSbqKAP5Ogfq95RTg--