From owner-svn-ports-all@freebsd.org Thu Aug 9 14:29:54 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B86E71068009 for ; Thu, 9 Aug 2018 14:29:54 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc29.google.com (mail-yw1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 31257754F6 for ; Thu, 9 Aug 2018 14:29:53 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc29.google.com with SMTP id w76-v6so4355928ywg.4 for ; Thu, 09 Aug 2018 07:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qBLwN/SLC6uMCkUSpuj/EjlquRcyNfXRPbHJpLmqkHI=; b=SD0gLzON6ibQhywkMJIea1H5QkpA4sGT6QKfdpVebWxVaEwoChXcCpTzdWxI7XcbhX StHUexAFAUplITBEUU/IlWUKWBMB0TGzCw++N35ccNv1qmja/V7FaPZ8/3t7oPeMRmdq hyI4qm5Xpx6dBWW5fvu3eUObKqCRiXLxpcuSNzc35nKdK1FvjJECVUWuD6NWbUk7taVn gQ6R/2WM5/PDv8m/7sy2GCPtv+wTZQNufMxNn7xFYf7iAWnPBqJB6+NJA/cD/AIoEVfG nwGckjJ98OqwIUHURp2rot6+mOoZK4iF+1nhUOdRlNNBnOhWuC7LoyaNHlAfPBtLVu0W kPzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qBLwN/SLC6uMCkUSpuj/EjlquRcyNfXRPbHJpLmqkHI=; b=bY0kH2e5kLVpf83EK6yT0ScshJysK9MDQsZbZz78Xgb0D905bg6zGSrGfziNr8I6+E cgMQAT3UxGPJU1DTao/8VVc9n9N3IsiMX710vtQfIyWbxdv4YSBwiQCTcdoU+eEomvvC 0BUUCO/QLQNVWnL2A/PiDUI8/0Mu8IiYBT+LKcpQC8MQY0GRNKuM8fM6oDQusmyxNoja 66eS8vj22mzNGUvyO62TA9Sk7qAl3WNwkzTVRx2YHF3cUWTquYejZwAuao+av1cQp+M6 tfPh+K3TQZ/qdPNkj9QzYRr7HwWZ6sbYzCTSDlCNKMsZEavTfaIWkp3EsnTU9ERreJFb O1Cw== X-Gm-Message-State: AOUpUlHSdytYtFU7G0IrUMW9N9nkGJCWGM1LeC9Zn7qBH/GDWQ+uG4c8 8I7YX+eB9k71tae80RK5BJPDBy6uMLMJzZNtvjnCOQ== X-Google-Smtp-Source: AA+uWPy0a3o9FI506UbjexURTSmjfOaoQmec1EyqLPPAvUmRZEbXcr2LuLbjvn7SYttGvaUWw3LI+ZCHOmHpfqUGRDk= X-Received: by 2002:a0d:fd87:: with SMTP id n129-v6mr1150544ywf.439.1533824993195; Thu, 09 Aug 2018 07:29:53 -0700 (PDT) MIME-Version: 1.0 References: <201808081953.w78Jr68X078029@repo.freebsd.org> <20180808202929.GA63276@exodus.zi0r.com> <20180808213446.gktmjqcyrfhjkrlk@atuin.in.mat.cc> <20180808215702.GB52659@exodus.zi0r.com> <8632EEE8-AFFE-4BE6-8E58-CE83F7C9036E@feld.me> In-Reply-To: <8632EEE8-AFFE-4BE6-8E58-CE83F7C9036E@feld.me> From: Adam Weinberger Date: Thu, 9 Aug 2018 08:29:36 -0600 Message-ID: Subject: Re: svn commit: r476670 - in head/devel: . rubygem-solve To: feld@feld.me Cc: zi@freebsd.org, mat@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 14:29:55 -0000 On Thu, Aug 9, 2018 at 6:30 AM Mark Felder wrote: > > > > > On Aug 8, 2018, at 17:18, Adam Weinberger wrote: > > > > On Wed, Aug 8, 2018 at 3:57 PM Ryan Steinmetz wrote: > >> > >> > >> On (08/08/18 23:34), Mathieu Arnold wrote: > >>>>> Ryan, > >>>>> > >>>>> You've just added a number of ports with uninformative pkg-descrs, = and > >>>>> unhelpful COMMENT strings. These aren't merely formalities. Users > >>>>> should be able to read the pkg-descr and understand if it's the rig= ht > >>>>> package for them, and COMMENT is the first target for searches. > >>>>> Please, go back over them and, at the very least, expand the pkg-de= scr > >>>>> files with more information. As a general rule, pkg-descr should NE= VER > >>>>> be the same text as the COMMENT. > >>>> > >>>> Adam, > >>>> > >>>> These are the description strings from authors of the code. They ca= me from > >>>> either rubygems.org and/or the gem source repository. For example, = in the > >>>> case of rubygem-solve: > >>>> > >>>> https://rubygems.org/gems/solve > >>>> > >>>> https://github.com/berkshelf/solve > >>>> > >>>> If you have any specific things you would like to see added to any o= f the > >>>> individual ports, please let me know. > >>> > >>> pkg-descr must contain sentences, something that can be read. It must= at > >>> least be two lines long, so that it is descriptive enough. The fact > >>> that upstream is crappy does not mean you can put he same crap in the > >>> ports tree. It is your job as committer to make sure that ports conf= orm > >>> to our policies and requirements. If upstream does not provide a bet= ter > >>> decription, create one, basd on your knowledge of the software. > >> > >> > >> https://svnweb.freebsd.org/ports/head/devel/p5-Data-Serializer-Sereal/= pkg-descr?revision=3D401986&view=3Dmarkup > >> > >> https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-afnic/pkg= -descr?revision=3D380380&view=3Dmarkup > >> > >> https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-smallregi= stry/pkg-descr?view=3Dmarkup > >> > >> https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-secdns/pk= g-descr?revision=3D380380&view=3Dmarkup > > > > Ryan, what exactly is it that you're arguing in favour of here? All I > > requested was for you to please add some helpful information in the > > descrs where possible. So far you've argued that uninformative descrs > > are okay as long as you copied it from someone else, and that > > uninformative descrs are okay because you're not the only one who does > > it. > > > > I'm trying to get people on board with fixing what's been an ongoing > > problem in our ports. You've agreed with the problem, but not the > > solution. If you have another solution to terse descrs that's > > different from putting more information in descrs, I'm eager to hear > > it. > > > > Adam, please stop. You cannot honestly expect committers to invent descri= ptions for ports that have zero documentation. I have plenty of ports mysel= f that only exist in the tree because I had to chase dependencies for the s= oftware I intended to port. Most of these are libraries that have non-descr= ipt or "too-clever" names and of which I have no idea what their function i= s. It is not my responsibility nor the responsibility of any committer to f= ix this problem. Okay, heard. I'll drop it. I don't think that copying and pasting the first sentence or two of the documentation that every module/library provides on the WWW is onerous, but if it's not our responsibility then it's not our responsibility. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org