From owner-freebsd-sparc64@FreeBSD.ORG Mon Jun 28 14:09:38 2004 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF37A16A4CE for ; Mon, 28 Jun 2004 14:09:38 +0000 (GMT) Received: from ida.interface-business.de (ida.interface-business.de [193.101.57.9]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F92E43D1F for ; Mon, 28 Jun 2004 14:09:38 +0000 (GMT) (envelope-from j@ida.interface-business.de) Received: by ida.interface-business.de (Postfix, from userid 107) id 778287A49; Mon, 28 Jun 2004 16:09:37 +0200 (MET DST) Date: Mon, 28 Jun 2004 16:09:37 +0200 From: Joerg Wunsch To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= Message-ID: <20040628160937.D21248@ida.interface-business.de> References: <20040627005719.M38063@cvs.imp.ch> <20040627090642.A75210@ida.interface-business.de> <20040627101539.G38063@cvs.imp.ch> <20040627115951.C75210@ida.interface-business.de> <20040627160033.G75210@ida.interface-business.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: ; from des@des.no on Mon, Jun 28, 2004 at 01:20:25PM +0200 X-Phone: +49-351-31809-14 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Organization: interface systems GmbH, Dresden cc: dhcp-hackers@isc.org cc: sparc64@freebsd.org Subject: Re: 64-bit time_t safe lease time X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Joerg Wunsch List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2004 14:09:38 -0000 As Dag-Erling Smørgrav wrote: > The attached patch addresses these inconsistencies, but I have not > verified that it corrects the 64-bit time_t problem. It seems to work, too. I backed out Martin Blapp's previous + my GET_TIME() patch, and applied your one. I get a few compilation warnings: cc -O -pipe -DCLIENT_PATH='"PATH=/sbin:/bin:/usr/sbin:/usr/bin"' -Dwarn=dhcp_warn -g -I/usr/src/sbin/dhclient/client/../../../contrib/isc-dhcp/includes -DENABLE_POLLING_MODE -DNOMINUM -c /usr/src/contrib/isc-dhcp/client/dhclient.c /usr/src/contrib/isc-dhcp/client/dhclient.c: In function `write_client_lease': /usr/src/contrib/isc-dhcp/client/dhclient.c:2458: warning: passing arg 1 of `gmtime' from incompatible pointer type /usr/src/contrib/isc-dhcp/client/dhclient.c:2468: warning: passing arg 1 of `gmtime' from incompatible pointer type /usr/src/contrib/isc-dhcp/client/dhclient.c:2478: warning: passing arg 1 of `gmtime' from incompatible pointer type but the resulting client appears to work fine: # dhclient -v gem0 Internet Systems Consortium DHCP Client V3.0.1rc14 Copyright 2004 Internet Systems Consortium. All rights reserved. For info, please visit http://www.isc.org/products/DHCP Listening on BPF/gem0/08:00:20:fe:a2:6e Sending on BPF/gem0/08:00:20:fe:a2:6e Sending on Socket/fallback DHCPDISCOVER on gem0 to 255.255.255.255 port 67 interval 8 DHCPOFFER from 193.101.57.34 DHCPREQUEST on gem0 to 255.255.255.255 port 67 DHCPACK from 193.101.57.34 bound to 193.101.57.70 -- renewal in 39365 seconds. That looks reasonable. -- J"org Wunsch Unix support engineer joerg_wunsch@interface-systems.de http://www.interface-systems.de/~j/