Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jun 2004 16:09:37 +0200
From:      Joerg Wunsch <j@ida.interface-business.de>
To:        =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
Cc:        sparc64@freebsd.org
Subject:   Re: 64-bit time_t safe lease time
Message-ID:  <20040628160937.D21248@ida.interface-business.de>
In-Reply-To: <xzp1xk0ylmu.fsf@dwp.des.no>; from des@des.no on Mon, Jun 28, 2004 at 01:20:25PM %2B0200
References:  <20040627005719.M38063@cvs.imp.ch> <20040627090642.A75210@ida.interface-business.de> <20040627101539.G38063@cvs.imp.ch> <20040627115951.C75210@ida.interface-business.de> <20040627160033.G75210@ida.interface-business.de> <xzp1xk0ylmu.fsf@dwp.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help
As Dag-Erling Smørgrav wrote:

> The attached patch addresses these inconsistencies, but I have not
> verified that it corrects the 64-bit time_t problem.

It seems to work, too.  I backed out Martin Blapp's previous + my
GET_TIME() patch, and applied your one.  I get a few compilation
warnings:

cc -O -pipe  -DCLIENT_PATH='"PATH=/sbin:/bin:/usr/sbin:/usr/bin"' -Dwarn=dhcp_warn -g -I/usr/src/sbin/dhclient/client/../../../contrib/isc-dhcp/includes -DENABLE_POLLING_MODE -DNOMINUM  -c /usr/src/contrib/isc-dhcp/client/dhclient.c
/usr/src/contrib/isc-dhcp/client/dhclient.c: In function `write_client_lease':
/usr/src/contrib/isc-dhcp/client/dhclient.c:2458: warning: passing arg 1 of `gmtime' from incompatible pointer type
/usr/src/contrib/isc-dhcp/client/dhclient.c:2468: warning: passing arg 1 of `gmtime' from incompatible pointer type
/usr/src/contrib/isc-dhcp/client/dhclient.c:2478: warning: passing arg 1 of `gmtime' from incompatible pointer type

but the resulting client appears to work fine:

# dhclient -v gem0
Internet Systems Consortium DHCP Client V3.0.1rc14
Copyright 2004 Internet Systems Consortium.
All rights reserved.
For info, please visit http://www.isc.org/products/DHCP

Listening on BPF/gem0/08:00:20:fe:a2:6e
Sending on   BPF/gem0/08:00:20:fe:a2:6e
Sending on   Socket/fallback
DHCPDISCOVER on gem0 to 255.255.255.255 port 67 interval 8
DHCPOFFER from 193.101.57.34
DHCPREQUEST on gem0 to 255.255.255.255 port 67
DHCPACK from 193.101.57.34
bound to 193.101.57.70 -- renewal in 39365 seconds.

That looks reasonable.

-- 
J"org Wunsch					       Unix support engineer
joerg_wunsch@interface-systems.de        http://www.interface-systems.de/~j/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040628160937.D21248>