Date: Fri, 20 Jan 2017 12:20:14 +0000 (UTC) From: "Tobias C. Berner" <tcberner@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r431949 - in head/devel/py-pykde4: . files Message-ID: <201701201220.v0KCKEI5015586@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: tcberner Date: Fri Jan 20 12:20:14 2017 New Revision: 431949 URL: https://svnweb.freebsd.org/changeset/ports/431949 Log: Fix py-pykde4 against newest clang PyList_SET_ITEM() is supposed to be void, but as a macro it's an expression and has a pointer value. Clang 4.0 trips on the bogus pointer comparison; given the comparison, it should be PyList_SetItem() which returns -1 on failure. As the produced code may be changed by this, bump PORTREVISION. PR: 216253 Submitted by: Adriaan de Groot <groot@kde.org> Reported by: jbeich Reviewed by: rakuco, tcberner Approved by: rakuco (mentor) Differential Revision: https://reviews.freebsd.org/D9253 Added: head/devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip (contents, props changed) head/devel/py-pykde4/files/patch-sip_solid_powermanagement.sip (contents, props changed) head/devel/py-pykde4/files/patch-sip_solid_predicate.sip (contents, props changed) Modified: head/devel/py-pykde4/Makefile Modified: head/devel/py-pykde4/Makefile ============================================================================== --- head/devel/py-pykde4/Makefile Fri Jan 20 11:46:50 2017 (r431948) +++ head/devel/py-pykde4/Makefile Fri Jan 20 12:20:14 2017 (r431949) @@ -2,7 +2,7 @@ PORTNAME= pykde4 PORTVERSION= ${KDE4_VERSION} -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= devel kde kde-kde4 python PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} Added: head/devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/py-pykde4/files/patch-sip_phonon_abstractvideodataoutput.sip Fri Jan 20 12:20:14 2017 (r431949) @@ -0,0 +1,16 @@ +PyList_SET_ITEM() is supposed to be void, but as a macro it's an +expression and has a pointer value. Clang 4.0 trips on the bogus +pointer comparison; given the comparison, it should be PyList_SetItem() +which returns -1 on failure. + +--- sip/phonon/abstractvideodataoutput.sip.orig 2014-08-14 20:17:11 UTC ++++ sip/phonon/abstractvideodataoutput.sip +@@ -72,7 +72,7 @@ protected: + foreach (Phonon::Experimental::VideoFrame2::Format value, set) + { + PyObject *obj = PyInt_FromLong ((long) value); +- if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0) ++ if (obj == NULL || PyList_SetItem (l, i, obj) < 0) + { + Py_DECREF(l); + Added: head/devel/py-pykde4/files/patch-sip_solid_powermanagement.sip ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/py-pykde4/files/patch-sip_solid_powermanagement.sip Fri Jan 20 12:20:14 2017 (r431949) @@ -0,0 +1,13 @@ +See patch-sip_phonon_abstractvideodataoutput.sip + +--- sip/solid/powermanagement.sip.orig 2014-08-14 20:17:11 UTC ++++ sip/solid/powermanagement.sip +@@ -83,7 +83,7 @@ bool stopSuppressingS + #else + PyObject *obj = PyInt_FromLong ((long) value); + #endif +- if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0) ++ if (obj == NULL || PyList_SetItem (l, i, obj) < 0) + { + Py_DECREF(l); + Added: head/devel/py-pykde4/files/patch-sip_solid_predicate.sip ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/py-pykde4/files/patch-sip_solid_predicate.sip Fri Jan 20 12:20:14 2017 (r431949) @@ -0,0 +1,13 @@ +See patch-sip_phonon_abstractvideodataoutput.sip + +--- sip/solid/predicate.sip.orig 2014-08-14 20:17:11 UTC ++++ sip/solid/predicate.sip +@@ -112,7 +112,7 @@ Py_BEGIN_ALLOW_THREADS + #else + PyObject *obj = PyInt_FromLong ((long) value); + #endif +- if (obj == NULL || PyList_SET_ITEM (l, i, obj) < 0) ++ if (obj == NULL || PyList_SetItem (l, i, obj) < 0) + { + Py_DECREF(l); +
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701201220.v0KCKEI5015586>