From owner-svn-src-head@freebsd.org Mon Apr 11 05:53:35 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9E13B0A3BD; Mon, 11 Apr 2016 05:53:35 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-vk0-x230.google.com (mail-vk0-x230.google.com [IPv6:2607:f8b0:400c:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65CDA18F4; Mon, 11 Apr 2016 05:53:35 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-vk0-x230.google.com with SMTP id k1so199198761vkb.0; Sun, 10 Apr 2016 22:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=ecs2P9r/9F0RpuFSH5DCfo4Y5TAnNL2hU2AxL4X5nlo=; b=Sw4+okUAmq1sUjzKaVS2hlRwtYkkTwpY65pQB0TtXDNP2OF3xKVvsHae3c+A8Knjub G9Gt8Z+I+c9R0Gf5Rm4nYuw7X1WFzo/nPyTqVmGg+8F66gJMpN9wMFCRS41NC7E1F43B dlamcWkddEAfdOEXrh6d4XYBoDIMHGK3XGNQt7rM9N0XWzXuL+2HCTDa7GGYk8YArdQ6 HAnrEfSdBYlzS45NmiUmdAZCwAvoHNRkn5Pr5+GEhaprK3qLaqEZmog5XsyVB7C8rBsB jzRDRdRhHpA9U0dTy2RqVipseDdGiKdRyRASXevH+dQ0NSSKlTxDigoKbCzlyp6TK9Wa nnEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ecs2P9r/9F0RpuFSH5DCfo4Y5TAnNL2hU2AxL4X5nlo=; b=GvpnyJgyww21RhudxqCsje9Trx6hgxde3o8/5f8YBrL7mAGwAHP/ntEKIZc4hYXfgr JX0cCrOBhtcgh5qysE1M6WSqwWd3mBXltg5H+8b69Hc5OZ/6v6uQb00MvZAGi/CvuzlF i1S5u3UMB4APm4wzmNoHCq84DwRkXa4Ut4ASusOhOQe/z91nCzIj77y5nfeiYLvKjx44 s7txvsgc2j4l6mm8W03DgpmATFKCYFSevI7t1/F2LSnVcuGzA2Y9f7KUK7g5l9DhUUNB x/GddjidQ0AfBFrCTVB0aBwFfBGyJUpmRmHwAATy43pXv7fSbAq0lWJfcRWDljIzSXl3 WK1Q== X-Gm-Message-State: AD7BkJJ8op1LYsL8uIigOOvrZeqqgG7GKIqDilf2Eur/rxFc9HC92L83p5bc21oQancbEAkI1RsETyc6on+GTA== MIME-Version: 1.0 X-Received: by 10.176.65.73 with SMTP id j67mr10717573uad.24.1460354014569; Sun, 10 Apr 2016 22:53:34 -0700 (PDT) Sender: sepherosa@gmail.com Received: by 10.176.64.130 with HTTP; Sun, 10 Apr 2016 22:53:34 -0700 (PDT) In-Reply-To: <0FE57290-DFEA-4524-9A46-9532643BB9FA@panasas.com> References: <201604110328.u3B3SI9e070348@repo.freebsd.org> <0FE57290-DFEA-4524-9A46-9532643BB9FA@panasas.com> Date: Mon, 11 Apr 2016 13:53:34 +0800 X-Google-Sender-Auth: JLTJL35D_JTAxR3GuKP_BpzgwE8 Message-ID: Subject: Re: svn commit: r297802 - head/sys/dev/hyperv/vmbus From: Sepherosa Ziehau To: Ravi Pokala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 05:53:35 -0000 Yeah, sure. On Mon, Apr 11, 2016 at 1:23 PM, Ravi Pokala wrote: > Hi sephe, > > > > -----Original Message----- > From: on behalf of Sepherosa Ziehau > Date: 2016-04-10, Sunday at 20:28 > To: , , > Subject: svn commit: r297802 - head/sys/dev/hyperv/vmbus > >>Author: sephe >>Date: Mon Apr 11 03:28:17 2016 >>New Revision: 297802 >>URL: https://svnweb.freebsd.org/changeset/base/297802 >> >>Log: >> hyperv: Identify Hyper-V features and recommends properly >> >> Features bits will be used to detect devices, e.g. timers, which >> do not have corresponding event channels. >> >> ... >> >>+ op = HV_CPU_ID_FUNCTION_HV_INTERFACE; >>+ do_cpuid(op, regs); >>+ if (regs[0] != 0x31237648 /* HV#1 */) >>+ return (false); > > Could you make that a #defined constant, rather than a magic integer? > > Thanks, > > Ravi (rpokala@) > -- Tomorrow Will Never Die