From owner-freebsd-qa@FreeBSD.ORG  Sun Mar  7 02:40:13 2004
Return-Path: <owner-freebsd-qa@FreeBSD.ORG>
Delivered-To: freebsd-qa@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EE7BB16A4CE
	for <qa@hub.freebsd.org>; Sun,  7 Mar 2004 02:40:13 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E819F43D1D
	for <qa@hub.freebsd.org>; Sun,  7 Mar 2004 02:40:13 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.10/8.12.10) with ESMTP id i27AeDbv029154
	for <qa@freefall.freebsd.org>; Sun, 7 Mar 2004 02:40:13 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i27AeDoB029153;
	Sun, 7 Mar 2004 02:40:13 -0800 (PST)
	(envelope-from gnats)
Date: Sun, 7 Mar 2004 02:40:13 -0800 (PST)
Message-Id: <200403071040.i27AeDoB029153@freefall.freebsd.org>
To: qa@FreeBSD.org
From: "Cyrille Lefevre" <cyrille.lefevre@laposte.net>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation
	time
X-BeenThere: freebsd-qa@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Cyrille Lefevre <cyrille.lefevre@laposte.net>
List-Id: FreeBSD Quality Assurance <freebsd-qa.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-qa>
List-Post: <mailto:freebsd-qa@freebsd.org>
List-Help: <mailto:freebsd-qa-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Mar 2004 10:40:14 -0000

The following reply was made to PR bin/27483; it has been noted by GNATS.

From: "Cyrille Lefevre" <cyrille.lefevre@laposte.net>
To: "Peter Pentchev" <roam@ringlet.net>
Cc: <bug-followup@FreeBSD.org>, <freebsd-qa@FreeBSD.org>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Sat, 6 Mar 2004 02:29:47 +0100

 > On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
 > > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET
 2004)
 > > anyone to commit this PR ?
 > > thanks in advance.
 > >
 > [snip]
 > >      /* Begin user dialog at outer menu */
 > >      dialog_clear();
 > > +    if (getpid() == 1)
 > > +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max,
 FALSE);
 > >      while (1) {
 >
 > Just a minor comment: shouldn't RunningAsInit be used here instead of
 > a getpid() invocation? :)
 
 maybe, don't know in fact ?
 
 Cyrille Lefevre.
 -- 
 home: mailto:cyrille.lefevre@laposte.net