From owner-freebsd-current@freebsd.org Sat Jan 26 09:27:01 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA0CB14BACA4; Sat, 26 Jan 2019 09:27:01 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 83A7570E69; Sat, 26 Jan 2019 09:26:59 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [176.74.212.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id BB5CA2601FE; Sat, 26 Jan 2019 10:26:49 +0100 (CET) Subject: Re: usb/234503 already committed, but needs modification to cover more devices To: Mel Pilgrim , freebsd-current@freebsd.org, freebsd-usb@freebsd.org References: <3f9936d7-14ba-c820-3fe5-f767d968e52f@bluerosetech.com> From: Hans Petter Selasky Message-ID: <6c72d9bf-84ab-a9e7-598d-48f6301fa291@selasky.org> Date: Sat, 26 Jan 2019 10:24:27 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <3f9936d7-14ba-c820-3fe5-f767d968e52f@bluerosetech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 83A7570E69 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-6.24 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.turbocat.net]; NEURAL_HAM_SHORT(-0.62)[-0.624,0]; IP_SCORE(-3.30)[ip: (-9.52), ipnet: 88.99.0.0/16(-4.69), asn: 24940(-2.31), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2019 09:27:02 -0000 On 1/26/19 1:41 AM, Mel Pilgrim wrote: > A quirk for a USB flashdrive was added to head (r342657), but the > modification was too narrow.  The quirk affects all of the devices in > the Chipfancier SLC family, not just the one specific device for which > the quirk was added. > > I replied to usb/234503 about this, but as this is already in head, I'd > like someone to act on it and modify the quirk to cover all of the > devices in the family before 12.0-R comes out (and hopefully MFC to > stable before 11.3 comes out). > > As I wrote in the PR, I'm already running the patch in releng/11.2 in > production. It is not a problem to make a patch to ignore the idProduct field when matching. Will you make a patch for usb_quirk.c ? --HPS