From owner-cvs-src@FreeBSD.ORG  Tue Jan  3 23:16:29 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 849C016A420;
	Tue,  3 Jan 2006 23:16:29 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7678143D81;
	Tue,  3 Jan 2006 23:16:23 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 4D2C9BC84;
	Tue,  3 Jan 2006 23:16:21 +0000 (UTC)
To: Diomidis Spinellis <dds@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 03 Jan 2006 21:58:22 GMT."
	<200601032158.k03LwMGP031138@repoman.freebsd.org> 
Date: Wed, 04 Jan 2006 00:16:20 +0100
Message-ID: <88559.1136330180@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2006 23:16:30 -0000

In message <200601032158.k03LwMGP031138@repoman.freebsd.org>, Diomidis Spinellis writes:
>dds         2006-01-03 21:58:22 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             vfs_syscalls.c 
>  Log:
>  Normalize the tv_usec part of the utimes(2) arguments to ensure
>  that a file's atime and mtime are only set to correct fractional
>  second values (0-999999000ns with the current interface).
>  Prior to this change users could create files with values outside
>  that range.  Moreover, on 32-bit machines tv_usec offsets larger than
>  4.3s would result in an unnormalized AND wrong timestamp value,
>  due to overflow.

I think this is wrong.  We should return EINVAL if the fractional
part is not correct.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.