From owner-svn-src-all@freebsd.org Sat Dec 17 19:50:18 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2EE28C854FF for ; Sat, 17 Dec 2016 19:50:18 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wj0-x231.google.com (mail-wj0-x231.google.com [IPv6:2a00:1450:400c:c01::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B3441C35 for ; Sat, 17 Dec 2016 19:50:17 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wj0-x231.google.com with SMTP id v7so118497625wjy.2 for ; Sat, 17 Dec 2016 11:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Iypn/uBHDIhNpmTiUVA+eNQcs6wjD5Cp8JVKHgs7RTU=; b=IEbBzMFSZIcGHWPjE5gTNfXYhwjHP1BZmraThvSSwwpKa6X/WGyxII3NmVg8ioGEgM J4yL7FgtL4QTR2XB6QjLptuDyvUX/1xMqEkMsoozNNMV5rRyA8EUE+UIhT2WEPF2Kent PZBRJbucfJ66hvyzv/Wc9sXSeKOpk7//ONwRQe35B6cP6brrxq7CB759GHGfRF0xJuYv jAOGweHfXTIaSZ9U+J2/RZnREHzsavVj6PqhktVNdcW4/l+IrCkSRqpKkoJ4FfylLrKf kcCKJLVmW5OqMeC6//TRtgvOXR352lY/uGJ3/r0SVuq1mbWHejrqj4IbJFl3A3dXE4Hx 6Rsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Iypn/uBHDIhNpmTiUVA+eNQcs6wjD5Cp8JVKHgs7RTU=; b=S9wm4UD/9KVynfo4m7Qu3elztgA+wxDre42KlWEfNIeNjZGoXEZc+s9Ov078LiTsuN QuLjwZZJX5aFn61YTz9zO81SIiA8GqIjHGh6QyH01ipZplV1gKpp5odu1r1ILuHri//W AjDQvTGMo81oEOzOa8/KXqgL628QdwnKgdcuZ1doXiISy01WHELWMTZ8ADyhVpcLCcQU 6DiC1FXzU3bBax6WAbyRMAWNBX9VH004m3fgSGGtP0VjEmKEUZAN1bl67ggrV9Eu8bEe XSMivNiLofmY9CfW4wKWmy3D2Oq2+fAxNuoeA3sYgoGcQI5+iDnsrT7fDM633A7iC4ro Y5SA== X-Gm-Message-State: AKaTC0306pTE3SXPam+gM8kVtUrsAimKeJ7qbvmBYzUm/mP0/THwqj5ThuqWac6Mgsr5JZWPc/ABilYY3ZKwYV0b X-Received: by 10.194.87.103 with SMTP id w7mr7695297wjz.164.1482004215759; Sat, 17 Dec 2016 11:50:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.253.65 with HTTP; Sat, 17 Dec 2016 11:50:15 -0800 (PST) In-Reply-To: <20161212223354.GA16028@mithlond.kdm.org> References: <201610201942.u9KJgQOR062772@repo.freebsd.org> <20161212223354.GA16028@mithlond.kdm.org> From: Oliver Pinter Date: Sat, 17 Dec 2016 20:50:15 +0100 Message-ID: Subject: Re: svn commit: r307684 - head/sbin/camcontrol To: "Kenneth D. Merry" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2016 19:50:18 -0000 On 12/12/16, Kenneth D. Merry wrote: > On Sun, Dec 11, 2016 at 00:49:12 +0100, Oliver Pinter wrote: >> On 10/20/16, Kenneth D. Merry wrote: >> > Author: ken >> > Date: Thu Oct 20 19:42:26 2016 >> > New Revision: 307684 >> > URL: https://svnweb.freebsd.org/changeset/base/307684 >> > >> > Log: >> > For CCBs allocated on the stack, we need to clear the entire CCB, not >> > just >> > the header. Otherwise stack garbage can lead to random flags getting >> > set. >> > >> > This showed up as 'camcontrol rescan all' failing with EINVAL because >> > the >> > address type wasn't CAM_DATA_VADDR. >> > >> > sbin/camcontrol/camcontrol.c: >> > In rescan_or_reset_bus(), bzero the stack-allocated CCBs before >> > use instead of clearing the body. >> > >> > MFC after: 3 days >> > Sponsored by: Spectra Logic >> >> The MFC of this commit is missed both for 10-STABLE and 11-STABLE. Is >> this still in plan to do? > > Done, thanks for the reminder! Thanks! Slightly related problem what I found on one of my INVARIANTS enabled kernel is the following: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215356 . A similar change what this is required in smartmontools too. > > Ken > -- > Kenneth Merry > ken@FreeBSD.ORG >