From owner-freebsd-ports@FreeBSD.ORG Mon Nov 8 19:24:22 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACC20106566C for ; Mon, 8 Nov 2010 19:24:22 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3D9F38FC12 for ; Mon, 8 Nov 2010 19:24:21 +0000 (UTC) Received: by ewy28 with SMTP id 28so3130526ewy.13 for ; Mon, 08 Nov 2010 11:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :user-agent:date:message-id:mime-version:content-type; bh=CJvDdDA//4k7kmqobiTx/uadWYjz1EVJMfezGpa7XRs=; b=AwGMxLSNvibTzCC8kIUlZXiN2XrgdTONlSha/gj/ieAR/GvhMGR+/T6ltAJMNZEVYv 5B1CtxaKe4aCgnHFH6+T+wEPVBF0jJ88OAxoqEkyZVDXY3qmLipQ+lDZNbPqLdgf04Vr nrHDAzLnPAp1fQ3VKAMLtdVM2dOVDKMqsCHcs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:user-agent:date:message-id :mime-version:content-type; b=USXRz3ZtShXAqPxV2jH7QYaUNvaRNjSYVe+tuN6Cy2ni8/fC6veyRmmusboOrexsv3 kFuv/T78b6VNW+Z/koD2fmboJkC1H6lsiS6ebeGmhQfe2P1MDPMReUj9X4Oeu9o9seAy 8sszagkrNscNMBCzOKd3qIEHsNvNg9GmKErmA= Received: by 10.216.17.135 with SMTP id j7mr5280914wej.97.1289244260189; Mon, 08 Nov 2010 11:24:20 -0800 (PST) Received: from localhost ([109.169.29.56]) by mx.google.com with ESMTPS id l14sm178020weq.11.2010.11.08.11.23.56 (version=SSLv3 cipher=RC4-MD5); Mon, 08 Nov 2010 11:24:19 -0800 (PST) From: Anonymous To: Steven Kreuzer References: <0C4F959A-6AD4-414A-AEB0-C15F3BF245D6@freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) Date: Mon, 08 Nov 2010 22:23:33 +0300 Message-ID: <86d3qf62mi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Cc: mi@aldan.algebra.com, freebsd-ports@freebsd.org Subject: Re: devel/gdb Port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2010 19:24:22 -0000 Steven Kreuzer writes: > With the help of jhb@, I have a port of gdb 7.1 that has been modified > to recognize freebsd threads. I would like to get this added to the > ports tree but I would like some feedback as to how it should be > added. > > Currently, the latest version of gdb in the ports tree is 6.6 and its > under devel/gdb66. I was thinking of adding this as gdb71 but the > latest version of the 7.x branch is 7.2 and someone already created a > port for it (ports/151077) but it doesn't recognize threads. > > So, for the 7 branch, would it make sense to check in version 7.1 as > devel/gdb7 and eventually update it to 7.2, or should it be checked in > as devel/gdb71? > > shar file can be found at http://exit2shell.com/~skreuzer/patches/gdb71.shar - fix build with devel/readline[*] - explicitly disable xml/unwind/python support - drop gettext dep, unused Note, lang/gcc* (and lang/clang) searches in LOCALBASE by default unlike gcc in base. Having it in *FLAGS by default reduces difference between build using ports compiler and base one. [*] http://docs.freebsd.org/cgi/mid.cgi?AANLkTinkwsFXpXE=CxcDjTGPVo3aa8EQ1_ve0h3NiB5E %% --- gdb71/Makefile +++ gdb71/Makefile @@ -17,15 +17,21 @@ COMMENT= GNU GDB of newer version than comes with the system USE_BZIP2= yes USE_GMAKE= yes -USE_GETTEXT= yes USE_ICONV= yes GNU_CONFIGURE= yes -CONFIGURE_ENV+= CONFIGURED_M4=m4 CONFIGURED_BISON=byacc +CONFIGURE_ENV+= CONFIGURED_M4=m4 CONFIGURED_BISON=byacc LDFLAGS="${LDFLAGS}" CONFIGURE_ARGS= --program-suffix=${PORTVERSION:S/.//g} \ + --with-libiconv-prefix=${LOCALBASE} \ + --with-system-readline \ + --without-expat \ + --without-libunwind \ + --without-python \ --enable-target=all \ - --enable-tui --with-libiconv-prefix=${LOCALBASE} + --enable-tui CFLAGS:= ${CFLAGS:C/ +$//} # blanks at EOL creep in sometimes +CFLAGS+= -I${LOCALBASE}/include CFLAGS+= -DRL_NO_COMPAT +LDFLAGS+= -L${LOCALBASE}/lib EXCLUDE= dejagnu expect readline sim texinfo intl EXTRACT_AFTER_ARGS=| ${TAR} -xf - ${EXCLUDE:S/^/--exclude /} VER= ${PORTVERSION:S/.//} @@ -36,6 +42,11 @@ ONLY_FOR_ARCHS= i386 amd64 # untested elsewhere, might work .include +# XXX: add OSVERSION check after readline is removed from base +.if exists(${LOCALBASE}/lib/libreadline.so) +LIB_DEPENDS+= readline.6:${PORTSDIR}/devel/readline +.endif + .if ${ARCH} == "amd64" CONFIGURE_TARGET= x86_64-portbld-freebsd${OSREL} .endif @@ -43,11 +54,6 @@ CONFIGURE_TARGET= x86_64-portbld-freebsd${OSREL} post-patch: @${REINPLACE_CMD} -e 's/$$/ [GDB v${PORTVERSION} for FreeBSD]/' \ ${WRKSRC}/gdb/version.in - @${REINPLACE_CMD} -e 's/^READLINE/#READLINE/' \ - -e 's/^readline/#readline/' \ - -e 's,^LIBICONV =.*,LIBICONV=-L${LOCALBASE}/lib -liconv,' \ - ${WRKSRC}/gdb/Makefile.in - ${ECHO} 'READLINE = -lreadline' >> ${WRKSRC}/gdb/Makefile.in @${CP} ${FILESDIR}/fbsd-threads.c ${WRKSRC}/gdb do-install: %%