From owner-cvs-all@FreeBSD.ORG Sat Jul 23 18:54:36 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6969716A41F; Sat, 23 Jul 2005 18:54:36 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B7D343D46; Sat, 23 Jul 2005 18:54:35 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (adsl-64-171-187-230.dsl.snfc21.pacbell.net [64.171.187.230]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j6NIsYo5029534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 23 Jul 2005 11:54:35 -0700 Message-ID: <42E29269.4030305@root.org> Date: Sat, 23 Jul 2005 11:54:33 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050416) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Andrey A. Chernov" , cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org References: <20050723182455.6AD3516A442@hub.freebsd.org> In-Reply-To: <20050723182455.6AD3516A442@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: src/games/fortune/fortune fortune.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2005 18:54:36 -0000 Andrey A. Chernov wrote: > ache 2005-07-23 18:24:47 UTC > > FreeBSD src repository > > Modified files: > games/fortune/fortune fortune.c > Log: > My change, namely srandomdev() addition, was backed out even without > discussing with me, and I obviously disagree seeing that afterwards > (srandomdev() back out not fix any thing, it can only mask the problem). > > So, back out the back out and return srandomdev(). > > People who have problems with repeated quotes should use -D fortune > option for debugging to see is the problem in (1) /dev/random initialization > or in (2) fortune code itself. A bug in initializing /dev/random is a security issue and not one to be taken lightly. I hope whoever is affected by this puts some effort into debugging it. -- Nate