From owner-cvs-all Tue Jan 2 11:28: 9 2001 From owner-cvs-all@FreeBSD.ORG Tue Jan 2 11:28:06 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from gratis.grondar.za (grouter.grondar.za [196.7.18.65]) by hub.freebsd.org (Postfix) with ESMTP id 5C99237B404; Tue, 2 Jan 2001 11:28:01 -0800 (PST) Received: from grondar.za (root@gratis.grondar.za [196.7.18.133]) by gratis.grondar.za (8.11.1/8.11.1) with ESMTP id f02JRtO11317; Tue, 2 Jan 2001 21:27:57 +0200 (SAST) (envelope-from mark@grondar.za) Message-Id: <200101021927.f02JRtO11317@gratis.grondar.za> To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sig.c References: <200101021854.f02IsAI77591@freefall.freebsd.org> In-Reply-To: <200101021854.f02IsAI77591@freefall.freebsd.org> ; from John Baldwin "Tue, 02 Jan 2001 10:54:10 PST." Date: Tue, 02 Jan 2001 21:28:08 +0200 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > jhb 2001/01/02 10:54:10 PST > > Modified files: > sys/kern kern_sig.c > Log: > The previous commit wasn't entirely correct. At least one goto to the > out: label in psignal() did not grab sched_lock before trying to release > it. Also, the previous version had several cases where it grabbed > sched_lock before jumping to out: unneccessarily, so rework this a bit. > The runfast: and out: labels must be called with sched_lock released, and > the run: label must be called with it held. Appropriate mtx_assert()'s > have been added that should catch any bugs that may still be in this > code. It this likely to catch any or all of the CURRENT deadlocks? M -- Mark Murray Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message