Date: Fri, 8 Jun 2012 01:51:23 -0400 From: Eitan Adler <lists@eitanadler.com> To: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: disabling generic attach for hptrr Message-ID: <CAF6rxg=2qbsXLKyT5PhNw2nH-Rd=XGGfYHhtOwFC7ww1Yo9suA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
I was sent this patch by a user that has been having trouble with his
hardware until attach_generic was disabled in loader.conf.
Is there any reason to have this on by default? Would anyone object to
me committing this patch?
--
Eitan Adler
[-- Attachment #2 --]
diff -upNr a/share/man/man4/hptrr.4 b/share/man/man4/hptrr.4
--- a/share/man/man4/hptrr.4 2012-06-04 01:04:23.603262299 -0400
+++ b/share/man/man4/hptrr.4 2012-06-04 01:13:29.983218866 -0400
@@ -50,8 +50,8 @@ hptrr_load="YES"
The following tunables are settable from the loader:
.Bl -ohang
.It Va hw.hptrr.attach_generic
-set to 0 to deny driver attach to chips with generic Marvell (non-HighPoint)
-PCI identification. These chips are also supported by ata(4).
+set to 1 to permit driver attach to chips with generic Marvell (non-HighPoint)
+PCI identification. These chips are also supported by ata(4) and mvs(4).
Some vendors are using same chips, but without providing RAID BIOS.
.El
.Sh DESCRIPTION
@@ -112,7 +112,8 @@ This driver supersedes the older rr232x
.Xr ata 4 ,
.Xr cam 4 ,
.Xr hptmv 4 ,
-.Xr loader 8
+.Xr loader 8 ,
+.Xr mvs 4
.Sh HISTORY
The
.Nm
diff -upNr a/sys/dev/hptrr/hptrr_osm_bsd.c b/sys/dev/hptrr/hptrr_osm_bsd.c
--- a/sys/dev/hptrr/hptrr_osm_bsd.c 2012-06-04 00:41:57.387011767 -0400
+++ b/sys/dev/hptrr/hptrr_osm_bsd.c 2012-06-04 01:08:37.113299728 -0400
@@ -34,7 +34,7 @@
#include <dev/hptrr/os_bsd.h>
#include <dev/hptrr/hptintf.h>
-static int attach_generic = 1;
+static int attach_generic = 0;
TUNABLE_INT("hw.hptrr.attach_generic", &attach_generic);
static int hpt_probe(device_t dev)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=2qbsXLKyT5PhNw2nH-Rd=XGGfYHhtOwFC7ww1Yo9suA>