From owner-cvs-src@FreeBSD.ORG Tue Sep 12 11:40:35 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F423716A603; Tue, 12 Sep 2006 11:40:34 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8269043DB2; Tue, 12 Sep 2006 11:40:24 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 6899946CF9; Tue, 12 Sep 2006 07:40:23 -0400 (EDT) Date: Tue, 12 Sep 2006 12:40:23 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Mike Silbersack In-Reply-To: <20060912002456.I43498@odysseus.silby.com> Message-ID: <20060912123917.U83151@fledge.watson.org> References: <200609061356.k86DuZ0w016069@repoman.freebsd.org> <20060906091204.B6691@odysseus.silby.com> <20060906143204.GQ40020@FreeBSD.org> <20060906093553.L6691@odysseus.silby.com> <20060906150506.GA7069@rambler-co.ru> <20060911005435.A23530@odysseus.silby.com> <20060911142703.GF27667@FreeBSD.org> <20060912001916.S43498@odysseus.silby.com> <20060912002456.I43498@odysseus.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Gleb Smirnoff , Ruslan Ermilov , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in_pcb.c tcp_subr.c tcp_timer.c tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2006 11:40:35 -0000 On Tue, 12 Sep 2006, Mike Silbersack wrote: > On Tue, 12 Sep 2006, Mike Silbersack wrote: > >> On Mon, 11 Sep 2006, Gleb Smirnoff wrote: >> >>> The UMA zone can't be made smaller than it is, while IP port ranges can >>> vary in both directions. >> >> Hm, it can't be made smaller because we're using UMA_ZONE_NOFREE... why are >> we using that? Shouldn't locking handle that, rwatson? :) > > Hm, it's been UMA_ZONE_NOFREE since day one. The reason may or may not be > relevant after all the work rwatson has done with locking. Unless the monitoring model is changed, this remains 100% necessary, or we may find ourselves performing mutex operations on uninitialized mutexes, corrupting kernel memory, or exporting other kernel data structures improperly to user space. Robert N M Watson Computer Laboratory University of Cambridge