Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Sep 2003 13:50:06 -0600
From:      "Justin T. Gibbs" <gibbs@scsiguy.com>
To:        Doug Rabson <dfr@nlsystems.com>, arch@freebsd.org
Subject:   Re: kobj multiple inheritance
Message-ID:  <1423490000.1064260204@aslan.btc.adaptec.com>
In-Reply-To: <1064221837.15078.14.camel@herring.nlsystems.com>
References:  <1064221837.15078.14.camel@herring.nlsystems.com>

next in thread | previous in thread | raw e-mail | index | archive | help
> I believe that I have the kobj multiple inheritance changes about ready
> for committing now. I have locked up the class handling in kobj and I've
> re-done the method dispatch so that it is MP-safe without needing locks
> (I would appreciate a close look at that part by another pair of eyes).

I've only just glanced at these patches, but I don't see how the
method cache is now MP safe.  Aren't you still vulnerable to a cache
collision from two different threads performing an operation on the
same class?

I still believe that the concept of inherited interfaces is better
way to achieve multiple inheritance.  The methods I may want to
inherit need not be associated with what we currently call a device
class.  The nice thing about your approach is that it doesn't require
a massive rototilling of the drivers, but I fear it doesn't go far
enough toward providing flexible inheritence.

--
Justin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1423490000.1064260204>