From owner-svn-src-stable-12@freebsd.org Tue Dec 3 17:34:58 2019 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E26621B7002; Tue, 3 Dec 2019 17:34:58 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47S8J15FLRz3C7c; Tue, 3 Dec 2019 17:34:57 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yb1-xb41.google.com with SMTP id v15so1826222ybp.13; Tue, 03 Dec 2019 09:34:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+JbBfahZMu12RKD+yWuHKyVRyVJzng6jEawyu9FpCUU=; b=POqr0jLxzfKrHayjxaDmzlyxgEIkj/RL5XNluVaznoQmcVlf94InXcs8s3kdAHrZYn 93UwRZA7dcYgd+zlurpbASG5tcx1KlNh5rywdX1R8IVtFKRRKafRQcebQrAc/7/I73LQ jT0l9NtCanzJ55FJVPMRaEmgx4CaQXVIXERVs9vQTWWZ9/ZN311uW4yBGQr7izp20JG+ +XQ9JzOQMQpl8KqUMBw0yRFnE2e+w5levHREIOXzxUTKulcSiKfU14agT1JV+bJL+zxV wjBVZxh7+ibgdQOs8pp+2QfEZl4YfvLnYU7XKxQpnB4XCCzlofg3vSwRh0wRZiHknBMh DK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+JbBfahZMu12RKD+yWuHKyVRyVJzng6jEawyu9FpCUU=; b=StMUWize400e2TP2ZGFWKYwSciZqmdV1WXzEDEUhmsB8fevm3ypWACAgnik4bZZJew erh4A/Wp4n2L5OSCZzMvfXCchsQDojaW/v1SMb1iwpzhOxhkyKur2/Y7IofqMPVjQd6M bRVQoljJqlspMlxWNQltuVx33Dbryw2fP7zocJh/2Oy2EokXG5qCg+CwRZJpgvBVWjRk K7VA76IMN0QMdHY165yabJpII07xYv9uQJli13LZaUzgOXUMlDd5JvtiyaCDqO8Un2CP OLDyzPHcpHBRxcj47u6Q6zzRT4k+bNXnvr27/VOsBKECCGNdLcUXT8XWKMAalmS8Ln7u /Ibw== X-Gm-Message-State: APjAAAXgswiDy1h3VibU0V1Y6bciiW/YYXcHFpxir9Jm6Jarvlzei+ma alg+Kxoonwj8sKg7RZQ7G0iZUw/B X-Google-Smtp-Source: APXvYqwpG13Snsr/ZBfbTOPIAvB+sggSagaWQriHCCmAHiT2qt54GWqU/tw3m2bwV3602DwGWFdsfw== X-Received: by 2002:a25:d6cd:: with SMTP id n196mr5039293ybg.198.1575394496181; Tue, 03 Dec 2019 09:34:56 -0800 (PST) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id o69sm1723331ywd.38.2019.12.03.09.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2019 09:34:55 -0800 (PST) Sender: Alexander Motin Subject: Re: svn commit: r355333 - stable/12/sys/cam To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org References: <201912031642.xB3GgXRD089746@repo.freebsd.org> <1c18cdbb-2a6e-3cbb-048b-8f1f49a4cef5@FreeBSD.org> <1dbc23eac25b2c0cece884fc54734e02868d75c6.camel@freebsd.org> From: Alexander Motin Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raS5AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczM AAoJEIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLq A6xe6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHu uC5vgPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15Gc sS9YcQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9 TevwGsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCg lz65AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6ZAXgD tmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8FlvmI/c 40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt3ytU 8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZR1Ed EIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm59R8A EQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczMAAoJ EIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLqA6xe 6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHuuC5v gPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15GcsS9Y cQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9Tevw Gsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCglz4= Message-ID: <9f7bcc85-42a0-2a4c-2a78-1d65f64cca4a@FreeBSD.org> Date: Tue, 3 Dec 2019 12:34:55 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1dbc23eac25b2c0cece884fc54734e02868d75c6.camel@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47S8J15FLRz3C7c X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=POqr0jLx; dmarc=none; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::b41 as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-2.65 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-0.45)[ip: (1.98), ipnet: 2607:f8b0::/32(-2.24), asn: 15169(-1.94), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2019 17:34:58 -0000 On 03.12.2019 12:00, Ian Lepore wrote: > On Tue, 2019-12-03 at 11:54 -0500, Alexander Motin wrote: >> On 03.12.2019 11:47, Ian Lepore wrote: >>> On Tue, 2019-12-03 at 16:42 +0000, Alexander Motin wrote: >>>> Author: mav >>>> Date: Tue Dec 3 16:42:32 2019 >>>> New Revision: 355333 >>>> URL: https://svnweb.freebsd.org/changeset/base/355333 >>>> >>>> Log: >>>> MFC r341756 (by scottl): >>>> Don't allocate the config_intrhook separately from the softc, >>>> it's >>>> small >>>> enough that it costs more code to handle the malloc/free than >>>> it >>>> saves. >>>> >>> >>> If it's a situation where the called hook routine always does a >>> disestablish of the hook (and nothing else does so), just use >>> config_intrhook_oneshot() and you don't need to manage the data >>> struct >>> yourself at all. >> >> Right. That is what I have done in my later commit. The only downside >> of config_intrhook_oneshot() is that it require memory allocation unlike >> previous. > > Yeah, it's all about convenience rather than peformance. Usually when > I need an intrhook it's a "one device instance once at bootup" kind of > thing where performance doesn't matter much. I don't worry so much about performance as about need to have sleepable context. -- Alexander Motin