From owner-freebsd-amd64@FreeBSD.ORG Mon Jul 19 01:40:09 2010 Return-Path: Delivered-To: freebsd-amd64@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5BFA21065673 for ; Mon, 19 Jul 2010 01:40:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4C1998FC18 for ; Mon, 19 Jul 2010 01:40:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6J1e9Sm079385 for ; Mon, 19 Jul 2010 01:40:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6J1e9eP079384; Mon, 19 Jul 2010 01:40:09 GMT (envelope-from gnats) Date: Mon, 19 Jul 2010 01:40:09 GMT Message-Id: <201007190140.o6J1e9eP079384@freefall.freebsd.org> To: freebsd-amd64@FreeBSD.org From: Anonymous X-Mailman-Approved-At: Mon, 19 Jul 2010 03:52:37 +0000 Cc: Subject: Re: amd64/144405: [build] [patch] include /usr/obj/lib32 in cleanworld target on amd64 arch X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anonymous List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2010 01:40:09 -0000 The following reply was made to PR amd64/144405; it has been noted by GNATS. From: Anonymous To: Alexander Best Cc: bug-followup@freebsd.org Subject: Re: amd64/144405: [build] [patch] include /usr/obj/lib32 in cleanworld target on amd64 arch Date: Mon, 19 Jul 2010 05:33:37 +0400 Alexander Best writes: > i can't really think of a situation where somebody wants to remove all > the 64bit objs but keep the 32bit ones. I was concerned about cleanworld invoked by crossbuild breaking normal build when running concurrently but looks like that's not the case, i.e. $ make cleanworld TARGET=i386 # /usr/obj/i386.i386/lib32/usr/src doesn't wipe out lib32 for normal build (/usr/obj/lib32/usr/src). Since crossbuild encloses lib32 in its OBJTREE there is no need for MK_LIB32 check. --- b.diff begins here --- diff --git a/Makefile.inc1 b/Makefile.inc1 index 85669d5..2298eca 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -1512,7 +1512,7 @@ cleanworld: -chflags -R 0 ${OBJTREE}${.CURDIR} rm -rf ${OBJTREE}${.CURDIR}/* .endif -.if exists(${OBJTREE}/lib32${.CURDIR}) && ${MK_LIB32} != "no" +.if exists(${OBJTREE}/lib32${.CURDIR}) -rm -rf ${OBJTREE}/lib32${.CURDIR}/* -chflags -R 0 ${OBJTREE}/lib32${.CURDIR} rm -rf ${OBJTREE}/lib32${.CURDIR}/* --- b.diff ends here ---