From nobody Thu Oct 19 18:36:47 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBGdq5jKpz4xl4g; Thu, 19 Oct 2023 18:36:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBGdq3cfxz3W3n; Thu, 19 Oct 2023 18:36:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697740607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e6XaeGLIdyS+4pWpTUe891x6391CLivN9RCuKDcJLJY=; b=uxn11LbPIEY89tlEdmRWcIOqks5+MP66Sp3wecIKmE43b5dhJ1waiQpxlEEvpwu8RYnVyq ozY09FrOswUksO3c3yGMG5Gzct47hr7QS+Em8uje8tiFpGXuXnuhuFkuT/0+3Xm9Ax2sms XGtlctfabxbLiVWYTVn8AEI3c0dRM0UwzhUc+qxb4yeQ8XE0PhHn1xW4Wd3XznsS1fvdjl E2hQvOsEejcNt0KheP75O81LIY7ynQ6wpKogbhxZUh49D4FrzfZjJXd644vfpglrgjHKr0 XIjDvdlOpQKKX2SkOgOLNs71AHAUVuqHySnoa+yYH3A8gP3vaj9Jbn3Tzsfl3g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697740607; a=rsa-sha256; cv=none; b=DcCTEhxPuZB7mTiPoIS61plgRk3g+fa0OxE8aSAY7ln8fKAXg/+oWZDm0ePMmo5hqlZYbM R1rhqVOQwU7Z8+kRwCoMTHg0uIHqJkLUQHgXFA9iVjjviiioUGbYEhtH1gsecFsKaViOEg ICFRrPjZocbm99nkuPBQsWQ/azpXcquVtBS8d1Kfq1IZtxSwBJ0g+D26o7GWRE5xlSkPRk Mnlt/Plpip/1ZiHNWSzsaL3mTYpUH5JtloaQjRWewBA45tmHuB5Onq8ZxFvLczYc2TzfF9 2iRh6WBp1OYHZ1hVCsTJJdxWDasmz+G2bSCnJA3ASNYxcqnH2YVdfI1EBQo6jw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697740607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e6XaeGLIdyS+4pWpTUe891x6391CLivN9RCuKDcJLJY=; b=LYvZNTjr2KybQO3Jy2ARxZjuB3sZPYuQThxCNuIRJTphADo/WKS4rKUVpKu4+YtB2gyKbp J8y9Q5Rx7pVup3L+2SXiVprmF1xrkX16GNilLiuH3zEu4w1n4aIDADuGfZsxxLRxvmV/eJ b0HfXggVnbvmwXaxmtmEfVgEdtWhOmmskUgtABHAZEdK7xnril5+wh4pQ9LoScaXxZl3MK fzCFBPfgdjdNBPp+QseRnRwFkN6HU4xwsZ4RxPF0FSzH6ytzlYeL9zqBYf9T0BPsGy1HCb 5AvuqNC8ssPpGAXv0C/oDLWRaatpbUBCAEkdOPnA9zOHQ4NhRdxWk/g2HhlZvQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBGdq2kkSz10wH; Thu, 19 Oct 2023 18:36:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39JIalLm094355; Thu, 19 Oct 2023 18:36:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39JIalxJ094352; Thu, 19 Oct 2023 18:36:47 GMT (envelope-from git) Date: Thu, 19 Oct 2023 18:36:47 GMT Message-Id: <202310191836.39JIalxJ094352@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 6ed16d17333c - main - KTLS: Enable KTLS for receiving as well in TLS 1.3 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6ed16d17333c5b1895aff35ddc1d46834f53a9eb Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=6ed16d17333c5b1895aff35ddc1d46834f53a9eb commit 6ed16d17333c5b1895aff35ddc1d46834f53a9eb Author: Daiki Ueno AuthorDate: 2021-10-10 07:14:06 +0000 Commit: John Baldwin CommitDate: 2023-10-19 18:34:58 +0000 KTLS: Enable KTLS for receiving as well in TLS 1.3 This removes a guard condition that prevents KTLS being enabled for receiving in TLS 1.3. Use the correct sequence number and BIO for receive vs transmit offload. Obtained from: OpenSSL commit 7c78932b9a4330fb7c8db72b3fb37cbff1401f8b --- crypto/openssl/ssl/tls13_enc.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/crypto/openssl/ssl/tls13_enc.c b/crypto/openssl/ssl/tls13_enc.c index 861ecdf91701..39a27d926ce7 100644 --- a/crypto/openssl/ssl/tls13_enc.c +++ b/crypto/openssl/ssl/tls13_enc.c @@ -438,6 +438,7 @@ int tls13_change_cipher_state(SSL *s, int which) const EVP_CIPHER *cipher = NULL; #if !defined(OPENSSL_NO_KTLS) && defined(OPENSSL_KTLS_TLS13) ktls_crypto_info_t crypto_info; + void *rl_sequence; BIO *bio; #endif @@ -692,8 +693,7 @@ int tls13_change_cipher_state(SSL *s, int which) s->statem.enc_write_state = ENC_WRITE_STATE_VALID; #ifndef OPENSSL_NO_KTLS # if defined(OPENSSL_KTLS_TLS13) - if (!(which & SSL3_CC_WRITE) - || !(which & SSL3_CC_APPLICATION) + if (!(which & SSL3_CC_APPLICATION) || (s->options & SSL_OP_ENABLE_KTLS) == 0) goto skip_ktls; @@ -709,7 +709,10 @@ int tls13_change_cipher_state(SSL *s, int which) if (!ktls_check_supported_cipher(s, cipher, ciph_ctx)) goto skip_ktls; - bio = s->wbio; + if (which & SSL3_CC_WRITE) + bio = s->wbio; + else + bio = s->rbio; if (!ossl_assert(bio != NULL)) { SSLfatal(s, SSL_AD_INTERNAL_ERROR, ERR_R_INTERNAL_ERROR); @@ -717,19 +720,26 @@ int tls13_change_cipher_state(SSL *s, int which) } /* All future data will get encrypted by ktls. Flush the BIO or skip ktls */ - if (BIO_flush(bio) <= 0) - goto skip_ktls; + if (which & SSL3_CC_WRITE) { + if (BIO_flush(bio) <= 0) + goto skip_ktls; + } /* configure kernel crypto structure */ - if (!ktls_configure_crypto(s, cipher, ciph_ctx, - RECORD_LAYER_get_write_sequence(&s->rlayer), - &crypto_info, which & SSL3_CC_WRITE, iv, key, - NULL, 0)) + if (which & SSL3_CC_WRITE) + rl_sequence = RECORD_LAYER_get_write_sequence(&s->rlayer); + else + rl_sequence = RECORD_LAYER_get_read_sequence(&s->rlayer); + + if (!ktls_configure_crypto(s, cipher, ciph_ctx, rl_sequence, &crypto_info, + which & SSL3_CC_WRITE, iv, key, NULL, 0)) goto skip_ktls; /* ktls works with user provided buffers directly */ - if (BIO_set_ktls(bio, &crypto_info, which & SSL3_CC_WRITE)) - ssl3_release_write_buffer(s); + if (BIO_set_ktls(bio, &crypto_info, which & SSL3_CC_WRITE)) { + if (which & SSL3_CC_WRITE) + ssl3_release_write_buffer(s); + } skip_ktls: # endif #endif