From owner-freebsd-arch@FreeBSD.ORG Mon Jul 20 13:52:01 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C24CD106564A for ; Mon, 20 Jul 2009 13:52:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 92B988FC21 for ; Mon, 20 Jul 2009 13:52:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 350F846B06 for ; Mon, 20 Jul 2009 09:52:01 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 527028A09F for ; Mon, 20 Jul 2009 09:52:00 -0400 (EDT) From: John Baldwin To: arch@freebsd.org Date: Mon, 20 Jul 2009 09:51:56 -0400 User-Agent: KMail/1.9.7 References: <200907191725.n6JHPOBe049379@svn.freebsd.org> In-Reply-To: <200907191725.n6JHPOBe049379@svn.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200907200951.56551.jhb@freebsd.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 20 Jul 2009 09:52:00 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Subject: Re: svn commit: r195767 - in head: . cddl/lib cddl/lib/libctf cddl/lib/libdtrace gnu/lib/libdialog gnu/lib/libg2c gnu/lib/libobjc gnu/lib/libreadline gnu/lib/libregex lib lib/libalias/libalias lib/liba... X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2009 13:52:02 -0000 On Sunday 19 July 2009 1:25:24 pm Ken Smith wrote: > Author: kensmith > Date: Sun Jul 19 17:25:24 2009 > New Revision: 195767 > URL: http://svn.freebsd.org/changeset/base/195767 > > Log: > Bump the version of all non-symbol-versioned shared libraries in > preparation for 8.0-RELEASE. Add the previous version of those > libraries to ObsoleteFiles.inc and bump __FreeBSD_Version. > > Reviewed by: kib > Approved by: re (rwatson) I think we should figure out a plan for 9.0 for non-versioned libraries in the base system. If we are still going to bump most libraries every release, then I don't think symbol versioning is buying us much. I'm not sure if we want to just add versioning to all non-versioned libraries in the base system that aren't from contrib software, or if we want to relax the "bump everything" policy back to the older policy of "bump when you make the first ABI change" with a possible corollary of "add symbol versioning when you do". I'd probably vote for the latter. I know that someone missed bumping libm.so.2 at some point in the past because they didn't realize that a change adjusted the ABI. However, the same issue there exists with symbol versioning: you have to realize that you need to bump the version of a symbol. If we are going to trust our developers to manage the versions of versioned symbols, then we should trust them to manage non-versioned library versions as well. Or the contrapositive: if we do not trust them to manage non-versioned library versions, perhaps we can't trust them (us) to manage symbol versions either. I guess specifically I see a disconnect in that in our current policy we trust developers to know when a change is an ABI change for a library with versioned symbols, but we don't trust them to know when a change is an ABI change for a library without versioned symbols. Either we trust developers to recognize an ABI change or not. Whether or not the library has versioned symbols doesn't change that, and the resulting mess if we get it wrong is just as ugly in either case. -- John Baldwin