From owner-freebsd-embedded@FreeBSD.ORG Wed Jan 4 08:00:30 2012 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62FF2106568A; Wed, 4 Jan 2012 08:00:30 +0000 (UTC) (envelope-from stb@lassitu.de) Received: from gilb.zs64.net (gilb.zs64.net [IPv6:2001:470:1f0b:105e::1ea]) by mx1.freebsd.org (Postfix) with ESMTP id 184858FC1C; Wed, 4 Jan 2012 08:00:23 +0000 (UTC) Received: by gilb.zs64.net (Postfix, from stb@lassitu.de) id 712CE11607B; Wed, 4 Jan 2012 08:00:22 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=iso-8859-1 From: Stefan Bethke In-Reply-To: Date: Wed, 4 Jan 2012 09:00:21 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <091CDDB2-AF5D-4BD7-8AC2-EC0CC5A78E40@lassitu.de> References: To: Adrian Chadd X-Mailer: Apple Mail (2.1251.1) Cc: freebsd-embedded@freebsd.org Subject: Re: dev/etherswitch X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2012 08:00:30 -0000 Am 04.01.2012 um 05:24 schrieb Adrian Chadd: > Hi, >=20 > Take a look at: >=20 > = http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work/commit/b31c= 2bc80e8328924802b24682a9d5ea77b13ebf >=20 > You have one commit messages but multiple things: >=20 > * You've added 'pinon', which lets you set a default output value. I > know at least one board required it for enabling USB power, why's the > tplink need it? Yes, the TL-WR3420 and TL-WR3220 use GPIO 6 to control power to the USB. = (That info is in the commit message for that change to ar71xx_gpio.c) > * Why'd you flip on bit 13 in the AR91xx GPIO function register? And > comment out the USB led device? Sorry, ignore my changes to TP-WR1043ND{.hints} that's just me playing = around. (I've taken the soldering iron to my WR1043ND and added an = SD-Card socket to the SPI bus, using GPIO 1 as SPI_CS2, that's why the = pin definitions have changed. There's no driver for MMC/SD in SPI mode, = but maybe I can fix that some other time. :-) > * You also changed the delay to three and commented it out. :-) Yes, that is intentional: I'm back to the original iicbb.c code; we = might want to add the delay hint to it, but it's not strictly necessary. > Some of this may need to be thrown back in -HEAD. So, can you provide > some more background info so I can see what needs to be merged back? > :) That is my plan, give me a few days to untangle all the changes and = package them up nicely. Stefan --=20 Stefan Bethke Fon +49 151 14070811